New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/packages: TestLoadImportsGraph, TestRedundantQueries are not passing #30115

Closed
dmitshur opened this Issue Feb 6, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@dmitshur
Copy link
Member

dmitshur commented Feb 6, 2019

I noticed it on the build dashboard as part of #11811.

Git bisect points to CL 161317 (commit golang/tools@279ab8e). /cc @stamblerre

On my Mac:

tools $ git checkout 279ab8e0019826e01e5eaf7ee88a3c89a0e5678d^
tools $ go test -count=1 ./go/packages
ok  	golang.org/x/tools/go/packages	14.628s
tools $ git checkout 279ab8e0019826e01e5eaf7ee88a3c89a0e5678d
tools $ go test -count=1 ./go/packages
--- FAIL: TestLoadImportsGraph (1.94s)
    --- FAIL: TestLoadImportsGraph/GOPATH (0.96s)
        packages_test.go:112: wrong import graph: got <<  errors
              golang.org/fake/a
              golang.org/fake/b
            * golang.org/fake/c
            * golang.org/fake/e
            * golang.org/fake/subdir/d
            * golang.org/fake/subdir/d [golang.org/fake/subdir/d.test]
            * golang.org/fake/subdir/d.test
            * golang.org/fake/subdir/d_test [golang.org/fake/subdir/d.test]
              math/bits
              unsafe
              golang.org/fake/b -> errors
              golang.org/fake/b -> golang.org/fake/a
              golang.org/fake/c -> golang.org/fake/b
              golang.org/fake/c -> unsafe
              golang.org/fake/e -> golang.org/fake/b
              golang.org/fake/e -> golang.org/fake/c
              golang.org/fake/subdir/d [golang.org/fake/subdir/d.test] -> math/bits
              golang.org/fake/subdir/d.test -> golang.org/fake/subdir/d [golang.org/fake/subdir/d.test]
              golang.org/fake/subdir/d.test -> golang.org/fake/subdir/d_test [golang.org/fake/subdir/d.test]
              golang.org/fake/subdir/d.test -> os (pruned)
              golang.org/fake/subdir/d.test -> testing (pruned)
              golang.org/fake/subdir/d.test -> testing/internal/testdeps (pruned)
              golang.org/fake/subdir/d_test [golang.org/fake/subdir/d.test] -> golang.org/fake/subdir/d [golang.org/fake/subdir/d.test]
            >>, want <<  errors
              golang.org/fake/a
              golang.org/fake/b
            * golang.org/fake/c
            * golang.org/fake/e
            * golang.org/fake/subdir/d
              unsafe
              golang.org/fake/b -> errors
              golang.org/fake/b -> golang.org/fake/a
              golang.org/fake/c -> golang.org/fake/b
              golang.org/fake/c -> unsafe
              golang.org/fake/e -> golang.org/fake/b
              golang.org/fake/e -> golang.org/fake/c
            >>
    --- FAIL: TestLoadImportsGraph/Modules (0.98s)
        packages_test.go:112: wrong import graph: got <<  errors
              golang.org/fake/a
              golang.org/fake/b
            * golang.org/fake/c
            * golang.org/fake/e
            * golang.org/fake/subdir/d
            * golang.org/fake/subdir/d [golang.org/fake/subdir/d.test]
            * golang.org/fake/subdir/d.test
            * golang.org/fake/subdir/d_test [golang.org/fake/subdir/d.test]
              math/bits
              unsafe
              golang.org/fake/b -> errors
              golang.org/fake/b -> golang.org/fake/a
              golang.org/fake/c -> golang.org/fake/b
              golang.org/fake/c -> unsafe
              golang.org/fake/e -> golang.org/fake/b
              golang.org/fake/e -> golang.org/fake/c
              golang.org/fake/subdir/d [golang.org/fake/subdir/d.test] -> math/bits
              golang.org/fake/subdir/d.test -> golang.org/fake/subdir/d [golang.org/fake/subdir/d.test]
              golang.org/fake/subdir/d.test -> golang.org/fake/subdir/d_test [golang.org/fake/subdir/d.test]
              golang.org/fake/subdir/d.test -> os (pruned)
              golang.org/fake/subdir/d.test -> testing (pruned)
              golang.org/fake/subdir/d.test -> testing/internal/testdeps (pruned)
              golang.org/fake/subdir/d_test [golang.org/fake/subdir/d.test] -> golang.org/fake/subdir/d [golang.org/fake/subdir/d.test]
            >>, want <<  errors
              golang.org/fake/a
              golang.org/fake/b
            * golang.org/fake/c
            * golang.org/fake/e
            * golang.org/fake/subdir/d
              unsafe
              golang.org/fake/b -> errors
              golang.org/fake/b -> golang.org/fake/a
              golang.org/fake/c -> golang.org/fake/b
              golang.org/fake/c -> unsafe
              golang.org/fake/e -> golang.org/fake/b
              golang.org/fake/e -> golang.org/fake/c
            >>
--- FAIL: TestRedundantQueries (1.33s)
    --- FAIL: TestRedundantQueries/GOPATH (0.59s)
        packages_test.go:1276: Load("errors", "iamashamedtousethedisabledqueryname=errors") = [errors errors.test errors_test [errors.test]], wanted just the errors package
    --- FAIL: TestRedundantQueries/Modules (0.73s)
        packages_test.go:1276: Load("errors", "iamashamedtousethedisabledqueryname=errors") = [errors errors.test errors_test [errors.test]], wanted just the errors package
FAIL
FAIL	golang.org/x/tools/go/packages	16.487s

@gopherbot gopherbot added this to the Unreleased milestone Feb 6, 2019

@stamblerre stamblerre self-assigned this Feb 6, 2019

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Feb 6, 2019

Change https://golang.org/cl/161457 mentions this issue: go/packages: fix broken tests to handle changes to packagestest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment