Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/maintner: Github throttle guard and test coverage increase #30122

Open
Skarlso opened this issue Feb 7, 2019 · 1 comment · May be fixed by golang/build#16

Comments

@Skarlso
Copy link
Contributor

commented Feb 7, 2019

As part of the work for #29396 I increased the coverage considerably around github.go. I also introduced a guard around Github throttling and / or failing for some reason to respond.

Although it's this might not fix the related issue, I failed to find the correct solution on that regard. It's probably some race condition that I'm not seeing.

However, the related PR is still solid in regards to test coverage increase which I'm extracting into this issue so the other one may be researched by someone more acquainted with the related code.

@gopherbot

This comment has been minimized.

Copy link

commented Feb 7, 2019

Change https://golang.org/cl/157437 mentions this issue: maintner: make GitHub issue events consistent with API values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.