Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
install: Windows MSI installer should not set GOROOT #30132
The official Windows msi installer sets GOROOT, this is mostly harmless however causes a problem when dealing with multiple Go versions and may lead to unexpected behavior as the user may not be aware that GOROOT is set and is assuming will be inferred.
This has lead to reports like #30126 (mine)
The official install docs haven't recommended setting GOROOT since 1.10; the last remaining bit was https://go-review.googlesource.com/c/go/+/161758, which hopefully will be removed in the 1.12 release.
So unless there's a good reason to set GOROOT on Windows, I think the installer should follow the same rule.