Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Windows MSI installer should not set GOROOT #30132

Closed
AlexRouSg opened this issue Feb 8, 2019 · 6 comments

Comments

Projects
None yet
5 participants
@AlexRouSg
Copy link
Contributor

commented Feb 8, 2019

The official Windows msi installer sets GOROOT, this is mostly harmless however causes a problem when dealing with multiple Go versions and may lead to unexpected behavior as the user may not be aware that GOROOT is set and is assuming will be inferred.

This has lead to reports like #30126 (mine)

@andybons andybons added this to the Go1.13 milestone Feb 8, 2019

@andybons

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

@alexbrainman

This comment has been minimized.

Copy link
Member

commented Feb 9, 2019

I don't use installer myself, so I would not know what is the right thing to do here. What do you suggest we do?

Alex

@mvdan

This comment has been minimized.

Copy link
Member

commented Feb 9, 2019

The official install docs haven't recommended setting GOROOT since 1.10; the last remaining bit was https://go-review.googlesource.com/c/go/+/161758, which hopefully will be removed in the 1.12 release.

So unless there's a good reason to set GOROOT on Windows, I think the installer should follow the same rule.

@alexbrainman

This comment has been minimized.

Copy link
Member

commented Feb 9, 2019

I think the installer should follow the same rule.

I do not use Go installer, so I would not know. When I use / develop Go I use GOROOT in my scripts.

But, if it is safe to remove GOROOT from installer, we can do that.

Alex

@gopherbot

This comment has been minimized.

Copy link

commented Feb 21, 2019

Change https://golang.org/cl/163299 mentions this issue: cmd/release: don't set GOROOT in the Windows installer

@alexbrainman

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

@andybons CL 163299 LGTM assuming what Daniel said. But I do not know how to test the CL. I, probably, need some tools to build installer. How do I test the CL?

Thank you.

Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.