Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/maintner: GitHub issue becoming 404 is not reflected in model #30184

Open
dmitshur opened this issue Feb 12, 2019 · 1 comment

Comments

@dmitshur
Copy link
Member

commented Feb 12, 2019

GitHub issue #23772 is currently 404.

If it's possible to do so in the scope of the work that maintner already does (i.e., it doesn't require going out of its way), then it should detect that and set its NotExist field gets to true.

c, err := godata.Get(context.Background())
if err != nil {
	panic(err)
}
i := c.GitHub().Repo("golang", "go").Issue(23772)

fmt.Println(i.NotExist)

// Output: false (but should be true)

/cc @bradfitz @jmdobry

(This came up from #30182.)

@gopherbot

This comment has been minimized.

Copy link

commented Feb 12, 2019

Change https://golang.org/cl/161906 mentions this issue: cmd/gopherbot: handle 404 GitHub issues in freezeOldIssues task

gopherbot pushed a commit to golang/build that referenced this issue Feb 12, 2019
cmd/gopherbot: handle 404 GitHub issues in freezeOldIssues task
A GitHub issue can become 404. Attempting to lock it will produce a
404 response from the GitHub API. Don't treat it as a fatal error
when it happens.

Add a check for the NotExist field. This will help after golang/go#30184
is resolved.

Updates golang/go#30182

Change-Id: Ia04c59879909b1de00bd681606bfa331fe642cd4
Reviewed-on: https://go-review.googlesource.com/c/161906
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.