Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: RemoveAll can incorrectly return ENOENT #30197

Closed
ianlancetaylor opened this issue Feb 12, 2019 · 2 comments
Closed

os: RemoveAll can incorrectly return ENOENT #30197

ianlancetaylor opened this issue Feb 12, 2019 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.12

Comments

@ianlancetaylor
Copy link
Member

2018-10-30T16:23:44-f570b54/android-amd64-emulator
2018-10-31T19:29:56-f6f27bf/linux-amd64-stretch
2018-10-31T22:14:09-d086c5c/linux-386-sid
2018-11-01T20:29:34-02aa1ae/linux-arm-arm5spacemonkey
2018-11-02T07:30:03-f108158/netbsd-amd64-8_0
2018-11-02T23:22:57-1645dfa/freebsd-arm-paulzhol
2018-11-05T19:10:20-27920c8/darwin-arm64-mn4m2zdaios
2018-11-05T19:30:42-2ae8bf7/netbsd-amd64-8_0
2018-11-05T22:36:24-f1a9f1d/freebsd-386-11_2
2018-11-05T23:12:50-9e61973/darwin-arm64-mn4m2zdaios
2018-11-07T13:04:50-ac277d9/freebsd-386-10_3
2018-11-07T16:12:02-644ddaa/linux-mips
2018-11-09T05:36:50-8ebc9fb/linux-ppc64-buildlet
2018-11-12T20:44:22-039c208/freebsd-386-11_2
2018-11-12T20:44:22-039c208/linux-386-387
2018-11-12T20:46:43-07544c7/freebsd-386-11_2
2018-11-13T13:35:15-a48a666/openbsd-amd64-62
2018-11-14T00:22:40-6d620fc/freebsd-386-10_3
2018-11-14T20:35:41-c524da4/linux-ppc64-buildlet
2018-11-15T23:37:20-1460897/linux-ppc64-buildlet
2018-11-18T16:13:13-fe562ce/darwin-arm-mg912baios
2018-11-28T17:38:46-bfc54bb/dragonfly-amd64
2018-11-29T08:30:13-311d87d/freebsd-arm-paulzhol
2018-11-29T14:00:26-2b58ca6/freebsd-386-10_4
2018-11-29T18:49:31-04e12a5/linux-amd64
2018-11-29T19:01:01-689fae2/darwin-arm-mg912baios
2018-11-29T19:06:32-81a5c9c/darwin-arm-mg912baios
2018-11-29T19:06:32-81a5c9c/freebsd-arm-paulzhol
2018-11-29T22:08:05-438b954/freebsd-amd64-12_0
2018-11-29T22:23:02-2140975/openbsd-amd64-64
2018-12-03T20:26:04-54cbc5b/linux-amd64-nocgo
2018-12-04T22:19:57-8a5797a/freebsd-arm-paulzhol
2018-12-05T14:12:14-5e17278/darwin-arm-mg912baios
2018-12-05T18:18:12-35435b2/darwin-arm-mg912baios
2018-12-07T16:42:49-578667f/darwin-arm64-mn4m2zdaios
2018-12-11T16:41:35-ba60724/freebsd-386-11_1
2018-12-12T21:19:54-cc8ae42/openbsd-386-64
2018-12-13T03:42:20-cc5fb5d/freebsd-386-10_3
2018-12-14T01:04:07-7701306/linux-ppc64le-buildlet
2018-12-17T22:49:21-d924c33/freebsd-arm-paulzhol
2018-12-17T23:49:15-32b879c/dragonfly-amd64
2018-12-18T16:18:54-5777e97/freebsd-386-10_4
2018-12-19T15:47:36-d9e2ba4/dragonfly-amd64
2018-12-21T18:42:22-429bae7/linux-amd64-clang
2018-12-21T20:44:41-0005515/freebsd-386-11_2
2019-01-08T19:21:25-033b650/darwin-arm-mg912baios
2019-01-09T18:38:22-52cae27/linux-ppc64-buildlet
2019-01-14T23:37:39-462e902/linux-amd64-noopt
2019-01-17T17:05:37-2f99e88/freebsd-arm-paulzhol
2019-01-18T22:41:42-6f93f86/darwin-amd64-10_12
2019-01-21T05:30:12-e308807/linux-amd64-longtest
2019-02-11T18:18:45-701f6a2/android-amd64-emulator
2019-02-12T14:47:52-1edd2a3/linux-amd64-nocgo

First observed f570b54 30 Oct 16:23 2018 (865 commits ago)
Last observed  1edd2a3 12 Feb 14:47 2019 (4 commits ago)
80% chance failure is still happening
5.5% failure probability (48 of 862 commits)
Likely culprits:
    5% f570b54 crypto/cipher: make stream examples runnable in the playground
    5% 7836457 runtime: add physical memory scavenging test
    5% c803ffc runtime: scavenge large spans before heap growth
    5% db82a1b runtime: sysUsed spans after trimming
    4% 61d40c8 runtime: extend ReadMemStatsSlow to re-compute HeapReleased
    4% 78bb91c runtime: remove npreleased in favor of boolean
    4% b46bf02 runtime: separate scavenged spans
    4% 239341f runtime: add successor method to treap
    3% 5dd4d1f runtime: add predecessor method to treap
    3% 85143d3 os: add support for long path names on unix RemoveAll
Past failures:
  2b780af 04 Mar 00:01 2017 to 03e2a4d 04 Mar 01:20 2017
    100% failure probability (5 of 5 commits)
  333f764 12 Jan 15:46 2017 to b2a3b54 13 Jan 23:13 2017
    100% failure probability (10 of 10 commits)
@ianlancetaylor ianlancetaylor self-assigned this Feb 12, 2019
@ianlancetaylor ianlancetaylor added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 12, 2019
@ianlancetaylor ianlancetaylor added this to the Go1.12 milestone Feb 12, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/162078 mentions this issue: os: don't return ENOENT if directory removed before Fstatat

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/162197 mentions this issue: [release-branch.go1.12] os: don't return ENOENT if directory removed before Fstatat

gopherbot pushed a commit that referenced this issue Feb 13, 2019
@ianlancetaylor
[release-branch.go1.12] os: don't return ENOENT if directory removed …
fa5e4ba 
…before Fstatat

Updates #30197

Change-Id: I08b592fbd477d6879eb5d3b7fcbbc8322ea90103
Reviewed-on: https://go-review.googlesource.com/c/162078
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit cf4dc25)
Reviewed-on: https://go-review.googlesource.com/c/162197
nebulabox pushed a commit to nebulabox/go that referenced this issue Feb 18, 2019
@ianlancetaylor @nebulabox
os: don't return ENOENT if directory removed before Fstatat
0b537b7 
Fixes golang#30197

Change-Id: I08b592fbd477d6879eb5d3b7fcbbc8322ea90103
Reviewed-on: https://go-review.googlesource.com/c/162078
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
nebulabox pushed a commit to nebulabox/go that referenced this issue Feb 20, 2019
@ianlancetaylor @nebulabox
os: don't return ENOENT if directory removed before Fstatat
c4127fd 
Fixes golang#30197

Change-Id: I08b592fbd477d6879eb5d3b7fcbbc8322ea90103
Reviewed-on: https://go-review.googlesource.com/c/162078
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
2 participants
@ianlancetaylor @gopherbot