Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: cmd/go/internal/lockedfile: add Append function #30207

Open
Mottl opened this issue Feb 13, 2019 · 3 comments
Open

Proposal: cmd/go/internal/lockedfile: add Append function #30207

Mottl opened this issue Feb 13, 2019 · 3 comments

Comments

@Mottl
Copy link
Contributor

@Mottl Mottl commented Feb 13, 2019

This is a proposal of adding Append function to cmd/go/internal/lockedfile.
Append will act as Write, except that it will not truncate a file if it already exists.

@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Feb 13, 2019

Note that cmd/go/internal/lockedfile is internal, and thus cannot be imported from outside of its part of the source tree.

You probably want to pair this with a proposal to move lockedfile to publicly-visible location. 🙂

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Feb 13, 2019

A minor change to an internal-only interface does not really need a proposal.
The proposal here is really to export lockedfile as a public API.
I don't think we have enough experience yet to decide about that.
Maybe in six months, for the Go 1.14 cycle.

@rsc rsc added the Proposal-Hold label Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.