Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: tracking bug for tip.golang.org #30232

Closed
bradfitz opened this issue Feb 14, 2019 · 8 comments
Closed

x/website: tracking bug for tip.golang.org #30232

bradfitz opened this issue Feb 14, 2019 · 8 comments
Assignees
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Feb 14, 2019

This is a tracking but to make sure the new x/website codebase also does tip.golang.org (which runs on GKE + uses autocert now)

/cc @cnoellekb @katiehockman @andybons @dmitshur

@gopherbot gopherbot added this to the Unreleased milestone Feb 14, 2019
@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Feb 14, 2019

Looks like x/website still has the autocert code.

This bug might just be validating that the tip service still runs (it'll need slight tweaks) on the go-dashboard-dev staging project's GKE cluster.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Feb 14, 2019

As part of the changes of moving website into x/website, we have to make a decision about the future scope of tip.golang.org.

Previously, tip.golang.org served two purposes: it served the latest content from the main Go repository (e.g., https://tip.golang.org/doc/go1.12, the latest spec.html, latest stdlib package docs), and it was a test of whether Go at tip builds at all. If there was a toolchain breakage (e.g., early in cycle), the latest tip commit couldn't be deployed.

This is because to serve the website, the Go distribution had to be built together with the x/tools/cmd/godoc binary.

Now that the website is served from x/website/cmd/golangorg, it becomes possible to use a fixed stable version of Go (rather than the tip commit) to serve the latest content from the Go repository. That would make tip.golang.org more reliable and change its purpose to only serve the latest Go repo content, not to see if the latest tip commit builds successfully (we have https://build.golang.org/ for that).

(I left a comment about it in code review here.)

Thoughts on this?

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Feb 14, 2019

It was never a goal to report or indicate whether any particular thing built at all.

The main goal was just showing tip docs.

But a secondary goal was that changing cmd/godoc meant that cmd/godoc self-deployed with those code changes (or CSS, JS changes).

@dmitshur dmitshur added the Builders label Feb 14, 2019
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Feb 14, 2019

@cnoellekb Are you planning on working on this? If so, I'm happy to be a reviewer for the CLs. Otherwise I can take this and you can be a reviewer.

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 15, 2019

Change https://golang.org/cl/162908 mentions this issue: cmd/tip: start building website from x/website repository

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 15, 2019

Change https://golang.org/cl/162909 mentions this issue: cmd/tip: use bootstrap version of Go to build golangorg

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 15, 2019

Change https://golang.org/cl/162914 mentions this issue: cmd/tip: add staging deployment configuration

gopherbot pushed a commit to golang/build that referenced this issue Feb 19, 2019
We want to be able to test cmd/tip changes on staging before pushing
to production. This change adds configuration files to be used for
the staging environment.

Mirror the production environment, but use a staging-specific load
balancer IP, domain, and autocert GCS bucket (golang-tip-dev-autocert).

Also rename the existing production configuration files to mirror the
pattern in other directories. This is especially important now that
there are both production and staging configuration files.

Updates golang/go#30232

Change-Id: I11c8cf643654d2c5bfa4add50f9ac8ca6771606b
Reviewed-on: https://go-review.googlesource.com/c/162914
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented May 14, 2019

Change https://golang.org/cl/177217 mentions this issue: cmd/tip: use proxy.golang.org when building x/website

gopherbot pushed a commit to golang/build that referenced this issue May 14, 2019
The new x/website is built in module mode. Now that proxy.golang.org
is available publicly, cmd/tip can start using it for fetching modules
when building x/website.

Also make a change to newServeMux so that httpsOnlyHandler is only used
when HTTPS is turned on. That stops redirecting to HTTPS when HTTPS is
not being served, thereby fixing HTTP-only local development mode.

Updates golang/go#26872
Updates golang/go#30232
Updates golang/go#29206

Change-Id: If0382c45b9c99540adce3a894054730f5a7a9fdb
Reviewed-on: https://go-review.googlesource.com/c/build/+/177217
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators May 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.