Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gerritbot: handle Draft Pull Requests in a sensible way #30244

Open
dmitshur opened this issue Feb 15, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@dmitshur
Copy link
Member

commented Feb 15, 2019

GitHub has released a new feature today, Draft Pull Requests:

https://github.blog/2019-02-14-introducing-draft-pull-requests/

This is a tracking issue to make sure gerritbot handles such PRs, if people make them, in a way that makes sense.

We need to investigate and decide what needs to happen differently, if anything at all. It'll probably be easier to wait for draft PRs to be sent before starting the investigation. We can also tell how big of a deal it is then.

If we need to do anything, I suspect we want to set the Gerrit WIP bit to mirror the GitHub draft status. Or, if the intended use of draft PRs is to signal "DO NOT REVIEW" (rather than "DO NOT SUBMIT"), perhaps not importing into Gerrit until the draft status is removed is a good idea.

GitHub has added preview API support for both GitHub v3 and v4 APIs. The tracking issue for adding support for this to go-github is google/go-github#1120.

/cc @bradfitz @andybons

@gopherbot gopherbot added this to the Unreleased milestone Feb 15, 2019

@dmitshur dmitshur changed the title x/build/cmd/gerritbot: handle Draft Pull Requests in a coherent way x/build/cmd/gerritbot: handle Draft Pull Requests in a sensible way Feb 15, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Mar 27, 2019

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@gopherbot gopherbot closed this Mar 27, 2019

@dmitshur

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2019

Giving this more time.

@dmitshur dmitshur reopened this Mar 27, 2019

@gopherbot gopherbot closed this Mar 27, 2019

@dmitshur dmitshur reopened this Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.