Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: TestSyscallNoError failing for linux-arm #30258

Closed
katiehockman opened this issue Feb 15, 2019 · 4 comments
Closed

syscall: TestSyscallNoError failing for linux-arm #30258

katiehockman opened this issue Feb 15, 2019 · 4 comments

Comments

@katiehockman
Copy link
Member

@katiehockman katiehockman commented Feb 15, 2019

--- FAIL: TestSyscallNoError (0.03s)
    syscall_linux_test.go:363: expected 4294967295 / 2 / 4294967294, got 0 / 0 / 0

syscall_linux_test.go:363

Example: https://build.golang.org/log/1e8c8089747c97648063107719f0ab970caf6e9f

The test starting failing consistently after committing https://go-review.googlesource.com/c/go/+/138757, but that doesn't seem related.

/cc @bradfitz @ianlancetaylor

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Feb 15, 2019

Ian's theory was that the temp dir got moved to a nosuid filesystem. Probably a buildlet change.

I'll look.

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Feb 15, 2019

bradfitz@gdev:~/go/src$ gomote create linux-arm
user-bradfitz-linux-arm-0


bradfitz@gdev:~/go/src$ gomote run -system user-bradfitz-linux-arm-0 env
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
HOSTNAME=scaleway-prod-31
ARCH=armv7l
UBUNTU_SUITE=xenial
DOCKER_REPO=multiarch/ubuntu-debootstrap
DEBIAN_FRONTEND=noninteractive
SCW_BASE_IMAGE=scaleway/ubuntu:xenial
GO_BOOTSTRAP=/usr/local/go
GO_BUILD_KEY_PATH=/buildkey/gobuildkey
GO_BUILD_KEY_DELETE_AFTER_READ=true
IN_KUBERNETES=1
GO_BUILDER_ENV=host-linux-arm-scaleway
META_BUILDLET_BINARY_URL=https://storage.googleapis.com/go-builder-data/buildlet.linux-arm
HOME=/root
USER=root
WORKDIR=/workdir
GOROOT_BOOTSTRAP=/usr/local/go
GO_BUILDER_NAME=linux-arm
GO_BUILDER_FLAKY_NET=1
TMPDIR=/workdir/tmp
GOCACHE=/workdir/gocache


bradfitz@gdev:~/go/src$ gomote run -system user-bradfitz-linux-arm-0 cat /proc/mounts
none / aufs rw,relatime,si=77d1174,dio,dirperm1 0 0
proc /proc proc rw,nosuid,nodev,noexec,relatime 0 0
tmpfs /dev tmpfs rw,nosuid,mode=755 0 0
devpts /dev/pts devpts rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=666 0 0
sysfs /sys sysfs ro,nosuid,nodev,noexec,relatime 0 0
tmpfs /sys/fs/cgroup tmpfs ro,nosuid,nodev,noexec,relatime,mode=755 0 0
cgroup /sys/fs/cgroup/systemd cgroup ro,nosuid,nodev,noexec,relatime,xattr,release_agent=/lib/systemd/systemd-cgroups-agent,name=systemd 0 0
cgroup /sys/fs/cgroup/cpuset cgroup ro,nosuid,nodev,noexec,relatime,cpuset 0 0
cgroup /sys/fs/cgroup/memory cgroup ro,nosuid,nodev,noexec,relatime,memory 0 0
cgroup /sys/fs/cgroup/cpu,cpuacct cgroup ro,nosuid,nodev,noexec,relatime,cpu,cpuacct 0 0
cgroup /sys/fs/cgroup/net_cls,net_prio cgroup ro,nosuid,nodev,noexec,relatime,net_cls,net_prio 0 0
cgroup /sys/fs/cgroup/freezer cgroup ro,nosuid,nodev,noexec,relatime,freezer 0 0
cgroup /sys/fs/cgroup/perf_event cgroup ro,nosuid,nodev,noexec,relatime,perf_event 0 0
cgroup /sys/fs/cgroup/devices cgroup ro,nosuid,nodev,noexec,relatime,devices 0 0
cgroup /sys/fs/cgroup/blkio cgroup ro,nosuid,nodev,noexec,relatime,blkio 0 0
mqueue /dev/mqueue mqueue rw,nosuid,nodev,noexec,relatime 0 0
/dev/nbd0 /buildkey ext4 rw,relatime,data=ordered 0 0
tmpfs /workdir tmpfs rw,nosuid,nodev,relatime 0 0
/dev/nbd0 /etc/resolv.conf ext4 rw,relatime,data=ordered 0 0
/dev/nbd0 /etc/hostname ext4 rw,relatime,data=ordered 0 0
/dev/nbd0 /etc/hosts ext4 rw,relatime,data=ordered 0 0
shm /dev/shm tmpfs rw,nosuid,nodev,noexec,relatime,size=65536k 0 0
proc /proc/bus proc ro,nosuid,nodev,noexec,relatime 0 0
proc /proc/fs proc ro,nosuid,nodev,noexec,relatime 0 0
proc /proc/irq proc ro,nosuid,nodev,noexec,relatime 0 0
proc /proc/sys proc ro,nosuid,nodev,noexec,relatime 0 0
proc /proc/sysrq-trigger proc ro,nosuid,nodev,noexec,relatime 0 0
tmpfs /proc/timer_list tmpfs rw,nosuid,mode=755 0 0
tmpfs /proc/timer_stats tmpfs rw,nosuid,mode=755 0 0

Yes:

TMPDIR=/workdir/tmp
...
tmpfs /workdir tmpfs rw,nosuid,nodev,relatime 0 0

There's nosuid there.

Probably fine to detect that & skip the test. Fixing the buildlet environment fixes us, but doesn't fix other people with nosuid temp dirs.

@bradfitz bradfitz added the NeedsFix label Feb 15, 2019
@bradfitz bradfitz added this to the Go1.12 milestone Feb 15, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 15, 2019

Change https://golang.org/cl/162891 mentions this issue: syscall: skip TestSyscallNoError when temp dir is mounted nosuid

@gopherbot gopherbot closed this in 5fcc240 Feb 15, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 15, 2019

Change https://golang.org/cl/162818 mentions this issue: [release-branch.go1.12] syscall: skip TestSyscallNoError when temp dir is mounted nosuid

gopherbot pushed a commit that referenced this issue Feb 15, 2019
…r is mounted nosuid

Fixes #30258

Change-Id: I73b63eb9d3aca00f562fdc3af010e96269bb6b9c
Reviewed-on: https://go-review.googlesource.com/c/162891
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
(cherry picked from commit 5fcc240)
Reviewed-on: https://go-review.googlesource.com/c/162818
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
nebulabox added a commit to nebulabox/go that referenced this issue Feb 18, 2019
Fixes golang#30258

Change-Id: I73b63eb9d3aca00f562fdc3af010e96269bb6b9c
Reviewed-on: https://go-review.googlesource.com/c/162891
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
nebulabox added a commit to nebulabox/go that referenced this issue Feb 20, 2019
Fixes golang#30258

Change-Id: I73b63eb9d3aca00f562fdc3af010e96269bb6b9c
Reviewed-on: https://go-review.googlesource.com/c/162891
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
@golang golang locked and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.