Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/godoc: url flag's response recorder ignores body [1.12 backport] #30314

Closed
gopherbot opened this issue Feb 19, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@gopherbot
Copy link

commented Feb 19, 2019

@rhysh requested issue #30261 to be considered for backport to the next 1.12 minor release.

@gopherbot please backport to 1.12

@gopherbot

This comment has been minimized.

Copy link
Author

commented Feb 19, 2019

Change https://golang.org/cl/162985 mentions this issue: cmd/godoc: fix -url flag, add tests

gopherbot pushed a commit to golang/tools that referenced this issue Feb 19, 2019

[release-branch.go1.12] cmd/godoc: fix -url flag, add tests
This change adds a small number of integration tests for the godoc
command's -url flag, confirming that the behavior matches the local http
server tests in those cases. It fixes three bugs which prevent the -url
flag from working currently.

Fixes golang/go#30314

Change-Id: I0ca1fe81f9f186d0ca02b31674cc8654af434e92
Reviewed-on: https://go-review.googlesource.com/c/162907
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
(cherry picked from commit bb2d4193192d16d7b4f740befc0ddd495bf6f86b)
Reviewed-on: https://go-review.googlesource.com/c/162985
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
@agnivade

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

@dmitshur - Any idea why gopherbot didn't close this ?

@dmitshur

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

I've investigated. The reason gopherbot didn't close this issue when CL 162985 was merged, as part of its "close cherry pick issues" task, is because this issue did not have a patch release milestone (e.g., one like Go1.11.6). The relevant code is here.

@dmitshur

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

@andybons I suspect you didn't intentionally modify the milestone, it probably happened as part of making the Go 1.12 release.

For context, this is a backport issue for 1.12, and it has already been resolved via CL 162985. It didn't get closed by gopherbot due to a bug (#30342), which has a fix (CL 163205) waiting on review.

I'm going to move the milestone back to 1.12. I could close the issue myself, but I'd prefer to deploy the gopherbot fix and confirm that gopherbot closes it.

@dmitshur dmitshur modified the milestones: Go1.13, Go1.12 Feb 28, 2019

gopherbot pushed a commit to golang/build that referenced this issue Mar 1, 2019

cmd/gopherbot: support closing major release cherry-pick issues
The "close cherry pick issues" task has been working to close
cherry-pick issues when CLs are merged to release branches,
but only for issues with milestones like like 1.12.1, 1.12.2,
1.12.3, etc., not ones like 1.12. This change fixes that.

Output from a -dry-run run after this change:

	$ go run . -dry-run -only-run="close cherry pick issues"
	close-cherry-pick [dry-run]
		https://golang.org/issue/30314  x/tools/cmd/godoc: url flag's response recorder ignores body [1.12 backport]
	2019/02/21 14:00:43 [dry-run] would add comment to github.com/golang/go/issues/30314: Closed by merging 49d818b07734fb3230f2d00bc5d4453348348d24 to release-branch.go1.12.
	2019/02/21 14:00:43 [dry-run] would close golang.org/issue/30314
	2019/02/21 14:00:43 gopherbot ran in 217.391921ms

Fixes golang/go#30342

Change-Id: I93528e6cf724aba1894a7c640fbb75ec42bb2006
Reviewed-on: https://go-review.googlesource.com/c/163205
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

Copy link
Author

commented Mar 1, 2019

Closed by merging 49d818b07734fb3230f2d00bc5d4453348348d24 to release-branch.go1.12.

@gopherbot gopherbot closed this Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.