Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: doesn't close backport issues for first major release #30342

Closed
dmitshur opened this Issue Feb 21, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@dmitshur
Copy link
Member

dmitshur commented Feb 21, 2019

GopherBot has a "close cherry pick issues" task. It closes cherry-pick issues when CLs are merged to release branches, as GitHub only does that on merge to master.

It works when backporting into patch releases like 1.12.1, 1.12.2, 1.12.3, etc., but not when backporting into 1.12.

This happened in #30314 (comment).

I wrote an explanation for why it happens in #30314 (comment). I have a fix, will send CL.

/cc @agnivade @bradfitz @andybons

@dmitshur dmitshur self-assigned this Feb 21, 2019

@gopherbot gopherbot added this to the Unreleased milestone Feb 21, 2019

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Feb 21, 2019

Change https://golang.org/cl/163205 mentions this issue: cmd/gopherbot: support closing major release cherry-pick issues

@dmitshur

This comment has been minimized.

Copy link
Member Author

dmitshur commented Mar 1, 2019

This is deployed now, and gopherbot is doing the right thing, as can be seen at #30314 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.