Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/asn1: NullBytes and NullRawValue are incorrect #30414

Closed
DenisKarch opened this issue Feb 26, 2019 · 0 comments
Closed

encoding/asn1: NullBytes and NullRawValue are incorrect #30414

DenisKarch opened this issue Feb 26, 2019 · 0 comments

Comments

@DenisKarch
Copy link

@DenisKarch DenisKarch commented Feb 26, 2019

The current NullRawValue is {0 5 false [] []}.
According to a the definition of RawValue this is incorrect

// A RawValue represents an undecoded ASN.1 object.\\
type RawValue struct {
	Class, Tag int
	IsCompound bool
	Bytes      []byte
	FullBytes  []byte // includes the tag and length
}

the value should instead be {0 5 false [] [5 0]}.
This is currently causing parsing of rsaencrypted certs to fail

@DenisKarch DenisKarch closed this Feb 26, 2019
@DenisKarch DenisKarch changed the title crypto/x509: NullBytes and NullRawValue are incorrect encoding/asn1: NullBytes and NullRawValue are incorrect Feb 26, 2019
@DenisKarch DenisKarch reopened this Feb 26, 2019
@DenisKarch DenisKarch closed this Feb 27, 2019
@golang golang locked and limited conversation to collaborators Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.