Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: remove dependency on unicode #30440

Open
bradfitz opened this Issue Feb 27, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@bradfitz
Copy link
Member

bradfitz commented Feb 27, 2019

An unfortunate dependency on unicode has crept into the net package via context -> reflect, introduced mostly in mid 2017 in 538b3a5.

Make context depend on reflectlite instead and fix deps_test.go to enforce that net can't depend on unicode.

@bradfitz bradfitz added the NeedsFix label Feb 27, 2019

@bradfitz bradfitz added this to the Go1.13 milestone Feb 27, 2019

@fraenkel

This comment has been minimized.

Copy link
Contributor

fraenkel commented Feb 27, 2019

How much of the net sub-packages should depend on reflectlite? net/rpc and net/http are doable.

@bradfitz

This comment has been minimized.

Copy link
Member Author

bradfitz commented Feb 27, 2019

net/http already depends on the world. That's not a goal. And net/rpc is also pretty high level.

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Feb 27, 2019

Change https://golang.org/cl/164239 mentions this issue: net: remove dependency on unicode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.