Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: error if GOCACHE is set but is not an absolute path [1.12 backport] #30493

Closed
gopherbot opened this issue Mar 1, 2019 · 2 comments
Closed
Assignees
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 1, 2019

@oiooj requested issue #30447 to be considered for backport to the next 1.12 minor release.

@gopherbot please backport to 1.12

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Mar 1, 2019

Change https://golang.org/cl/164717 mentions this issue: [release-branch.go1.12] cmd/go/internal/cache: disable builds if GOCACHE is not an absolute path

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Mar 1, 2019

Closed by merging 162b361 to release-branch.go1.12.

@gopherbot gopherbot closed this Mar 1, 2019
gopherbot pushed a commit that referenced this issue Mar 1, 2019
…CHE is not an absolute path

If GOCACHE is set but is not an absolute path, we cannot build.
And GOCACHE=off also returns the error message "build cache is
disabled by GOCACHE=off".

Fixes #30493

Change-Id: I24f64bc886599ca0acd757acada4714aebe4d3ae
Reviewed-on: https://go-review.googlesource.com/c/164200
Run-TryBot: Baokun Lee <nototon@gmail.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
(cherry picked from commit 13d24b6)
Reviewed-on: https://go-review.googlesource.com/c/164717
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.