Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: MacOS binaries invalid for eventual Apple Notary [1.12 backport] #30526

Closed
gopherbot opened this issue Mar 1, 2019 · 14 comments

Comments

Projects
None yet
7 participants
@gopherbot
Copy link

commented Mar 1, 2019

@ianlancetaylor requested issue #30488 to be considered for backport to the next 1.12 minor release.

@gopherbot please open backport issues

@macetw

This comment has been minimized.

Copy link

commented Mar 12, 2019

How can I be recognized as the assignee, and with label "NeedsFix?"

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

@gopherbot please add label NeedsFix

@gopherbot gopherbot added the NeedsFix label Mar 12, 2019

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

@gopherbot please assign to macetw

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

Well, at least the label request worked.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

I can't seem to assign the issue to you anyhow. I wouldn't worry about it.

@andybons andybons modified the milestones: Go1.12.1, Go1.12.2 Mar 14, 2019

@andybons andybons modified the milestones: Go1.12.2, Go1.12.3, Go1.12.4, Go1.12.5 Apr 5, 2019

@andybons andybons modified the milestones: Go1.12.5, Go1.12.6 May 6, 2019

@pieterclaerhout

This comment has been minimized.

Copy link

commented May 7, 2019

Any idea when this will be released?

We're actually waiting for this fix to be able to notarize our binaries for macOS. Since Apple will be pushing this after WWDC beginning of june, it would be awesome to be ready…

@gopherbot

This comment has been minimized.

Copy link
Author

commented May 8, 2019

Change https://golang.org/cl/175919 mentions this issue: [release-branch.go1.12] cmd/link/internal/ld: bump macOS and macOS SDK version to 10.9

gopherbot pushed a commit that referenced this issue May 8, 2019

[release-branch.go1.12] cmd/link/internal/ld: bump macOS and macOS SD…
…K version to 10.9

Satisfies the Apple Notary.

Fixes #30526

Change-Id: I91cf2d706a3ebe79bafdb759a0d32266ed6b9096
Reviewed-on: https://go-review.googlesource.com/c/go/+/175918
Run-TryBot: Elias Naur <mail@eliasnaur.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/175919
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

Copy link
Author

commented May 8, 2019

Closed by merging cdb7765 to release-branch.go1.12.

@gopherbot gopherbot closed this May 8, 2019

@pieterclaerhout

This comment has been minimized.

Copy link

commented May 13, 2019

What's the target release date of go 1.12.6?

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

Likely around June 1. (CC @andybons)

@andybons

This comment has been minimized.

Copy link
Member

commented May 14, 2019

Ian is correct. Around June 1

@pieterclaerhout

This comment has been minimized.

Copy link

commented Jun 5, 2019

Hi, any update on the availability of Go 1.12.6?

@dmitshur

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

@pieterclaerhout The release should be available tomorrow, June 11th.

@pieterclaerhout

This comment has been minimized.

Copy link

commented Jun 13, 2019

I can confirm that with Go 1.12.6, notarization now works correctly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.