Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/compile: investigate wasm sync inlining #30605
https://go-review.googlesource.com/c/go/+/148958/ made sync.Mutex.Unlock inlinable.
It worked for Wasm, but then CL 164461 and CL 153797 landed and the resulting merge no longer passed the inlining tests.
As a quick fix, https://go-review.googlesource.com/c/go/+/165339 ignored wasm in the inlining tests.
Investigate & re-enable.
Fix builder breakage from CL 148958. This is an inlining test that should be skipped on -N -l. The inlining also doesn't happen on arm and wasm, so skip the test there too. Fixes the noopt builder, the linux-arm builder, and the wasm builder. Updates #30605 Change-Id: I06b90d595be7185df61db039dd225dc90d6f678f Reviewed-on: https://go-review.googlesource.com/c/go/+/165339 Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org>
The test now explains:
This applies to wasm since it has no atomic operations yet. The test needs to be reenabled after the threads proposal landed.