Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/exp/errors/fmt: TestPanics broken #30622

Open
eliasnaur opened this issue Mar 6, 2019 · 6 comments

Comments

@eliasnaur
Copy link
Contributor

commented Mar 6, 2019

From tip: https://build.golang.org/log/5dd20c71b5e4d2d29ae2230ab47058abb52d88e5

--- FAIL: TestPanics (0.00s)
    fmt_test.go:1684: 1: "%s": got "%!s(PANIC=String method: unexpected EOF)" expected "%!s(PANIC=unexpected EOF)"
    fmt_test.go:1684: 2: "%s": got "%!s(PANIC=String method: 3)" expected "%!s(PANIC=3)"
    fmt_test.go:1684: 4: "%#v": got "%!v(PANIC=GoString method: unexpected EOF)" expected "%!v(PANIC=unexpected EOF)"
    fmt_test.go:1684: 5: "%#v": got "%!v(PANIC=GoString method: 3)" expected "%!v(PANIC=3)"
    fmt_test.go:1684: 6: "%#v": got "[]interface {}{%!v(PANIC=GoString method: 3), %!v(PANIC=GoString method: 3)}" expected "[]interface {}{%!v(PANIC=3), %!v(PANIC=3)}"
    fmt_test.go:1684: 8: "%s": got "%!s(PANIC=Format method: unexpected EOF)" expected "%!s(PANIC=unexpected EOF)"
    fmt_test.go:1684: 9: "%s": got "%!s(PANIC=Format method: 3)" expected "%!s(PANIC=3)"
FAIL
FAIL	golang.org/x/exp/errors/fmt	0.109s

@gopherbot gopherbot added this to the Unreleased milestone Mar 6, 2019

@eliasnaur

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

@dmitshur dmitshur changed the title x/exp: errors/fmt.TestPanics broken x/exp/errors/fmt: TestPanics broken Sep 17, 2019

@dmitshur

This comment has been minimized.

Copy link
Member

commented Sep 17, 2019

Issue #32528 has been resolved, and so the tests for the golang.org/x/exp/errors module will be executed when trybots run. That means this test failure will affect all trybot runs in x/exp.

@dmitshur

This comment has been minimized.

Copy link
Member

commented Sep 17, 2019

I'm not familiar enough with this code to know how the test should be fixed. I can send a CL to skip this test on builders with a reference to this issue. It'd be good to have a fix sooner so that trybots can succeed on x/exp.

@gopherbot

This comment has been minimized.

Copy link

commented Sep 17, 2019

Change https://golang.org/cl/196034 mentions this issue: errors/fmt: disable failing TestPanics test on builders

gopherbot pushed a commit to golang/exp that referenced this issue Sep 18, 2019
errors/fmt: disable failing TestPanics test on builders
Now that golang/go#32528 has been resolved and inner modules
are being tested too, disable this failing test until it can
be fixed. We don't want to distract people trying to do other
work in x/exp with trybot failures.

Updates golang/go#30622

Change-Id: Ia6f9c2b64100c7a9056a013453caf6e6c76177ad
Reviewed-on: https://go-review.googlesource.com/c/exp/+/196034
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@jba

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2019

I think we can remove exp/errors; it's been obsoleted by xerrors and the 1.13 stdlib errors. @mpvl @neild can you confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.