Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: "website", "build" not on dashboard #30640

Closed
bradfitz opened this issue Mar 6, 2019 · 11 comments
Closed

x/build: "website", "build" not on dashboard #30640

bradfitz opened this issue Mar 6, 2019 · 11 comments

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Mar 6, 2019

https://build.golang.org/ doesn't have "website" listed.

Is that intentional?

@gopherbot gopherbot added this to the Unreleased milestone Mar 6, 2019
@gopherbot gopherbot added the Builders label Mar 6, 2019
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Mar 6, 2019

It might've been intentional when x/website was a work-in-progress, but now that it's the canonical website source, it should be on the dashboard.

@dmitshur dmitshur added NeedsFix and removed NeedsInvestigation labels Mar 6, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented May 16, 2019

Change https://golang.org/cl/177658 mentions this issue: app/appengine, dashboard: add x/website subrepo

gopherbot pushed a commit to golang/build that referenced this issue May 16, 2019
Updates golang/go#30640

Change-Id: I2926f45efa18530ce72fa4a7ecdc255839bd6f45
Reviewed-on: https://go-review.googlesource.com/c/build/+/177658
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jun 14, 2019

As mentioned in #32626, we should also add x/build subrepo to post-submit builders. /cc @bcmills

Only need limited builders (e.g., linux/amd64 on latest stable release) since it's our internal infrastructure repo, not meant for wide public consumption.

@dmitshur dmitshur changed the title x/build: "website" not on dashboard x/build: "website", "build" not on dashboard Jun 14, 2019
@dmitshur dmitshur removed their assignment Nov 18, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 20, 2019

Change https://golang.org/cl/207852 mentions this issue: app/appengine: add x/build to the build dashboard

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Nov 20, 2019

CL 207852 said "Fixes" but https://build.golang.org/ doesn't have x/build repo yet. Re-opening until it shows up so we don't lose track of this.

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Nov 20, 2019

I would've just deployed it then but I worried that @cagedmantis has pending CLs that he's deploying right now (e.g. farmer.golang.org says it's at revision fd0e1d889dc65cd1932ecb09eee047f261226535-amedee-20191119T162811)

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Nov 20, 2019

No worries. I just don't want us to lose track of this in case it ends up requiring more work after the deploy.

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Nov 24, 2019

It's on there now. I guess gitmirror finally slowly populated the x/build git history into datastore.

@bradfitz bradfitz closed this Nov 24, 2019
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Nov 25, 2019

It's on there now. I guess gitmirror finally slowly populated the x/build git history into datastore.

x/website too. I can't help but feel there must've been another reason why it appeared now and not in any of the last few months.

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Nov 25, 2019

@dmitshur, I also restarted gitmirror. And for x/build I manually created a datastore record. (not for x/website, though)

In any case, all this complicated code is being deleted in https://golang.org/cl/208697.

@gopherbot
Copy link

@gopherbot gopherbot commented Dec 12, 2019

Change https://golang.org/cl/211100 mentions this issue: dashboard: stop testing x/build on even more builders

gopherbot pushed a commit to golang/build that referenced this issue Dec 12, 2019
Follow up to CL 210378 after looking at:
https://build.golang.org/?repo=golang.org%2fx%2fbuild

Updates golang/go#30640

Change-Id: I81505a9ca2985ffa6e75922665b14ef4de2af860
Reviewed-on: https://go-review.googlesource.com/c/build/+/211100
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants