Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: "website", "build" not on dashboard #30640

Open
bradfitz opened this issue Mar 6, 2019 · 3 comments

Comments

Assignees

@dmitshur dmitshur

Labels
Builders NeedsFix
Projects
None yet
Milestone
  Unreleased
3 participants
@bradfitz @dmitshur @gopherbot
@bradfitz
Copy link
Member

commented Mar 6, 2019

https://build.golang.org/ doesn't have "website" listed.

Is that intentional?

@bradfitz bradfitz added the NeedsInvestigation label Mar 6, 2019

@bradfitz bradfitz assigned dmitshur Mar 6, 2019

@gopherbot gopherbot added this to the Unreleased milestone Mar 6, 2019

@gopherbot gopherbot added the Builders label Mar 6, 2019

@dmitshur

This comment has been minimized.

Sign in to view
Copy link
Member

commented Mar 6, 2019

It might've been intentional when x/website was a work-in-progress, but now that it's the canonical website source, it should be on the dashboard.

@dmitshur dmitshur added NeedsFix and removed NeedsInvestigation labels Mar 6, 2019

@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented May 16, 2019

Change https://golang.org/cl/177658 mentions this issue: app/appengine, dashboard: add x/website subrepo

gopherbot pushed a commit to golang/build that referenced this issue May 16, 2019

@dmitshur
app/appengine, dashboard: add x/website subrepo 
Updates golang/go#30640

Change-Id: I2926f45efa18530ce72fa4a7ecdc255839bd6f45
Reviewed-on: https://go-review.googlesource.com/c/build/+/177658
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
7aef06b
@dmitshur

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jun 14, 2019

As mentioned in #32626, we should also add x/build subrepo to post-submit builders. /cc @bcmills

Only need limited builders (e.g., linux/amd64 on latest stable release) since it's our internal infrastructure repo, not meant for wide public consumption.

@dmitshur dmitshur changed the title x/build: "website" not on dashboard x/build: "website", "build" not on dashboard Jun 14, 2019

@dmitshur dmitshur referenced this issue Jun 14, 2019

Closed

x/build/cmd/coordinator: fails 'go test' vet check at head #32626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.