Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: "website", "build" not on dashboard #30640

Closed
bradfitz opened this issue Mar 6, 2019 · 10 comments
Closed

x/build: "website", "build" not on dashboard #30640

bradfitz opened this issue Mar 6, 2019 · 10 comments
Assignees
@bradfitz
Labels
Builders NeedsFix help wanted
Milestone
Unreleased

Comments

@bradfitz
Copy link
Member

@bradfitz bradfitz commented Mar 6, 2019

https://build.golang.org/ doesn't have "website" listed.

Is that intentional?
@gopherbot gopherbot added this to the Unreleased milestone Mar 6, 2019
@gopherbot gopherbot added the Builders label Mar 6, 2019
@dmitshur

This comment has been minimized.

Sign in to view
Copy link
Member

@dmitshur dmitshur commented Mar 6, 2019

It might've been intentional when x/website was a work-in-progress, but now that it's the canonical website source, it should be on the dashboard.
@dmitshur dmitshur added NeedsFix and removed NeedsInvestigation labels Mar 6, 2019
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented May 16, 2019

Change https://golang.org/cl/177658 mentions this issue: app/appengine, dashboard: add x/website subrepo
gopherbot pushed a commit to golang/build that referenced this issue May 16, 2019
@dmitshur
app/appengine, dashboard: add x/website subrepo
7aef06b 
Updates golang/go#30640

Change-Id: I2926f45efa18530ce72fa4a7ecdc255839bd6f45
Reviewed-on: https://go-review.googlesource.com/c/build/+/177658
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@dmitshur

This comment has been minimized.

Sign in to view
Copy link
Member

@dmitshur dmitshur commented Jun 14, 2019

As mentioned in #32626, we should also add x/build subrepo to post-submit builders. /cc @bcmills

Only need limited builders (e.g., linux/amd64 on latest stable release) since it's our internal infrastructure repo, not meant for wide public consumption.
@dmitshur dmitshur changed the title x/build: "website" not on dashboard x/build: "website", "build" not on dashboard Jun 14, 2019
@dmitshur dmitshur mentioned this issue Jun 14, 2019
Closed
@dmitshur dmitshur removed their assignment Nov 18, 2019
@dmitshur dmitshur mentioned this issue Nov 18, 2019
Closed
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented Nov 20, 2019

Change https://golang.org/cl/207852 mentions this issue: app/appengine: add x/build to the build dashboard
@dmitshur

This comment has been minimized.

Sign in to view
Copy link
Member

@dmitshur dmitshur commented Nov 20, 2019

CL 207852 said "Fixes" but https://build.golang.org/ doesn't have x/build repo yet. Re-opening until it shows up so we don't lose track of this.
@dmitshur dmitshur reopened this Nov 20, 2019
@bradfitz

This comment has been minimized.

Sign in to view
Copy link
Member Author

@bradfitz bradfitz commented Nov 20, 2019

I would've just deployed it then but I worried that @cagedmantis has pending CLs that he's deploying right now (e.g. farmer.golang.org says it's at revision fd0e1d889dc65cd1932ecb09eee047f261226535-amedee-20191119T162811)
@dmitshur

This comment has been minimized.

Sign in to view
Copy link
Member

@dmitshur dmitshur commented Nov 20, 2019 •
edited

No worries. I just don't want us to lose track of this in case it ends up requiring more work after the deploy.
@bradfitz

This comment has been minimized.

Sign in to view
Copy link
Member Author

@bradfitz bradfitz commented Nov 24, 2019

It's on there now. I guess gitmirror finally slowly populated the x/build git history into datastore.
@bradfitz bradfitz closed this Nov 24, 2019
@dmitshur

This comment has been minimized.

Sign in to view
Copy link
Member

@dmitshur dmitshur commented Nov 25, 2019

It's on there now. I guess gitmirror finally slowly populated the x/build git history into datastore.

x/website too. I can't help but feel there must've been another reason why it appeared now and not in any of the last few months.
@bradfitz

This comment has been minimized.

Sign in to view
Copy link
Member Author

@bradfitz bradfitz commented Nov 25, 2019

@dmitshur, I also restarted gitmirror. And for x/build I manually created a datastore record. (not for x/website, though)

In any case, all this complicated code is being deleted in https://golang.org/cl/208697.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bradfitz bradfitz

Labels
Builders NeedsFix help wanted
Projects
None yet
Milestone
  Unreleased
3 participants
@bradfitz @dmitshur @gopherbot
You can’t perform that action at this time.