net/http: Server.Shutdown doc example bug: no exit on error

[justinfx]

It appears the doc example that is provided for http.Server.Shutdown has a bug.
https://godoc.org/net/http#Server.Shutdown

The example shows that when the listener returns, it only prints the error as opposed to being fatal. This would cause the process to block on the done channel until SIGINT is actually sent.

Reproduction of bug:
https://play.golang.org/p/LCSLoMWIMrR

Should the error handling use log.Fatal?

[agnivade]

Ok, so you are talking about cases where the listener returns on its own without calling Shutdown or Close, in which case, it won't be an ErrServerClosed.

Let's see what @bradfitz says.

[justinfx]

That's correct. My included reproduction shows a case where a bad address was provided so the listener fails immediately. But it won't exit because its waiting on the graceful shutdown channel, which never gets touched.

[agnivade]

@bradfitz thoughts ?

[agnivade]

Fixed with 04e2e81