Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/goimports: adds circular imports #30663

Closed
stamblerre opened this issue Mar 7, 2019 · 1 comment
Closed

x/tools/cmd/goimports: adds circular imports #30663

stamblerre opened this issue Mar 7, 2019 · 1 comment

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Mar 7, 2019

goimports will add an import for the package you are currently in if you make a mistake.

Repro:

Open a file in golang.org/x/tools/internal/lsp/source and replace "View" with "source.View". An import for golang.org/x/tools/internal/lsp/source will be added by goimports.

@gopherbot gopherbot added this to the Unreleased milestone Mar 7, 2019
@andybons andybons added the NeedsFix label Mar 9, 2019
@stamblerre stamblerre removed gopls labels Mar 12, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 31, 2019

Change https://golang.org/cl/170238 mentions this issue: imports: fix circular imports

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.