Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: module loader looks for the wrong tags if the "go-import" prefix includes the major-version suffix [1.12 backport] #30665

Closed
gopherbot opened this issue Mar 7, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@gopherbot
Copy link

commented Mar 7, 2019

@bcmills requested issue #30647 to be considered for backport to the next 1.12 minor release.

@gopherbot, please backport to 1.12: this fixes a regression from GOPATH mode and the patch is small.

@gopherbot

This comment has been minimized.

Copy link
Author

commented Mar 8, 2019

Change https://golang.org/cl/166317 mentions this issue: [release-branch.go1.12] cmd/go/internal/modfetch: handle codeRoot == path for paths with major-version suffixes

@gopherbot

This comment has been minimized.

Copy link
Author

commented Mar 8, 2019

Closed by merging 4dd46a6 to release-branch.go1.12.

@gopherbot gopherbot closed this Mar 8, 2019

gopherbot pushed a commit that referenced this issue Mar 8, 2019

[release-branch.go1.12] cmd/go/internal/modfetch: handle codeRoot == …
…path for paths with major-version suffixes

Fixes #30665

Change-Id: Icbcfdb3907bc003ac17a8c7df17ecb41daf82eb4
Reviewed-on: https://go-review.googlesource.com/c/go/+/166117
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
(cherry picked from commit 1ab9f68)
Reviewed-on: https://go-review.googlesource.com/c/go/+/166317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.