Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go build -mod=readonly should disallow go.sum updates #30667

Open
rsc opened this Issue Mar 8, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@rsc
Copy link
Contributor

rsc commented Mar 8, 2019

go build -mod=readonly disallows go.mod updates.
It should also disallow go.sum updates.
Maybe it already does; I haven't checked.

@marwan-at-work

This comment has been minimized.

Copy link
Contributor

marwan-at-work commented Mar 8, 2019

can confirm that -mod=readonly does not disallow go.sum updates.

go mod init reproduce 
go get github.com/pkg/errors
echo "" > go.sum
go build -mod=readonly
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Mar 8, 2019

Change https://golang.org/cl/166237 mentions this issue: cmd/go: disallow go.sum updates in -mod=readonly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.