Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/x/text/unicode/bidi: remove generated 'example_test.go' which is build-ignored #30671

Open
leonklingele opened this issue Mar 8, 2019 · 2 comments

Comments

@leonklingele
Copy link
Contributor

@leonklingele leonklingele commented Mar 8, 2019

example_test.go in internal/x/text/unicode/bidi will never build due to the +build ignore build constraint. Can this file be removed? See also #30021.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Mar 8, 2019

That's odd. There is no such file in the source package golang.org/x/text/unicode/bidi, and as far as I can tell there never was one. The file first appeared in the main repo in https://golang.org/cl/37111.

The file says that it was generated by gen.go, but I can't figure out how or from what.

CC @mpvl in case he remembers.

@agnivade

This comment has been minimized.

Copy link
Contributor

@agnivade agnivade commented Mar 22, 2019

ping @mpvl ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.