Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: trybots on release branches sometimes didn't show Go version #30747

Closed
dmitshur opened this Issue Mar 11, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@dmitshur
Copy link
Member

dmitshur commented Mar 11, 2019

There are three entries for "linux-amd64" on the trybot status page. One of them is for tip, the other for Go 1.12 release branch, and the last for Go 1.11 release branch. They used to have this information displayed in parenthesis, but not now:

This may be related to the recent refactor. /cc @bradfitz

@dmitshur dmitshur added the Builders label Mar 11, 2019

@dmitshur dmitshur added this to the Unreleased milestone Mar 11, 2019

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Mar 11, 2019

Weird. I don't see how I might've broken that, but I agree it's probably related to the massive https://go-review.googlesource.com/c/build/+/166218

@bradfitz bradfitz self-assigned this Mar 11, 2019

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Mar 11, 2019

The CL in question (type from the screenshot) was https://go-review.googlesource.com/c/tools/+/166877

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Mar 11, 2019

I can't reproduce.

I removed the TryBot-Result vote from that CL and watched maintq:

$ maintq try-work
waiting:<project:"tools" branch:"master" change_id:"Idaa0bb72bf896bb8addc0004f17c3e97f8cc8b7a" commit:"8ec0247ba501b9479de91b14734dddae63441274" go_commit:"486ca37b14f56b2e125fc3afbd900a5369532043" go_commit:"4dd46a678fec26ff05b0ef1cf43aa4531dfa192a" go_commit:"8390781ca35ac5874eb5b136cfc29bb47adee94b" go_branch:"master" go_branch:"release-branch.go1.12" go_branch:"release-branch.go1.11" go_version:<major:1 minor:12 > go_version:<major:1 minor:12 > go_version:<major:1 minor:11 > > 

And then watched its trybots re-run, and here's what I see:

Screen Shot 2019-03-11 at 12 39 23 PM

So, uh, works for me?

@bradfitz bradfitz assigned dmitshur and unassigned bradfitz Mar 11, 2019

@dmitshur

This comment has been minimized.

Copy link
Member Author

dmitshur commented Mar 11, 2019

I can't reproduce it now either:

(From https://farmer.golang.org/try?commit=8ec0247b.)

It happened only on the first run of trybots in CL 166877, but not 2nd or 3rd.

I'll try running trybots for the first time on a fresh CL to see if that produces different results.

@dmitshur dmitshur changed the title x/build/cmd/coordinator: trybots on release branches don't show Go version x/build/cmd/coordinator: trybots on release branches sometimes didn't show Go version Mar 12, 2019

@dmitshur

This comment has been minimized.

Copy link
Member Author

dmitshur commented Mar 13, 2019

I haven't seen this since that one time, even for new CLs. I'll close this and re-open if I see it happen again.

@dmitshur dmitshur closed this Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.