Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestLldbPython newly failing (related to enabling modules) #30751

Closed
josharian opened this issue Mar 11, 2019 · 6 comments
Closed

cmd/go: TestLldbPython newly failing (related to enabling modules) #30751

josharian opened this issue Mar 11, 2019 · 6 comments
Assignees
Milestone

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Mar 11, 2019

On darwin/amd64, running all.bash at tip, I get:

--- FAIL: TestLldbPython (2.12s)
    runtime-lldb_test.go:163: building source exit status 1
        go: cannot find main module; see 'go help modules'
FAIL
FAIL	runtime	26.998s

The test passed this morning. :)

cc @bcmills @jayconrod

@mikioh

This comment has been minimized.

Copy link
Contributor

@mikioh mikioh commented Mar 20, 2019

It might be better to run "/usr/sbin/DevToolsSecurity -enable" on darwin buildbots by default.

@josharian

This comment has been minimized.

Copy link
Contributor Author

@josharian josharian commented Mar 20, 2019

Sure. But this was on my local machine. And we don’t want to ask everyone who runs all.bash (often only once) to jump through any hoops. So the test still needs to be resilient.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Mar 28, 2019

Change https://golang.org/cl/169725 mentions this issue: runtime: fix TestLldbPython test with modules enabled

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Mar 28, 2019

What does DevToolsSecurity -enable have to do with this?

@gopherbot gopherbot closed this in 722b1ab Mar 28, 2019
@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Mar 28, 2019

On darwin/amd64, running all.bash at tip

Do we know why this issue didn't show up in the builders? (Should we expand the darwin/amd64 builders in some way to enable them to catch regressions of this test?)

@josharian

This comment has been minimized.

Copy link
Contributor Author

@josharian josharian commented Mar 28, 2019

Do we know why this issue didn't show up in the builders? (Should we expand the darwin/amd64 builders in some way to enable them to catch regressions of this test?)

Good question. Maybe that's why @mikioh meant by suggesting that we run /usr/sbin/DevToolsSecurity -enable on the builders. I'll open a new issue for that a bit later (have to run now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.