Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/dist: add test that Go can bootstrap itself with just-built tree #30758

Closed
bradfitz opened this issue Mar 12, 2019 · 1 comment
Closed

cmd/dist: add test that Go can bootstrap itself with just-built tree #30758

bradfitz opened this issue Mar 12, 2019 · 1 comment

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Mar 12, 2019

CL 166985 broke the build, but in a way that the build system didn't detect: it produced a build that couldn't be used to as a GOROOT_BOOTSTRAP directory.

We should add a test (perhaps off by default, except on at least 1 builders, including trybots) that just runs make.bash again using the just-built tree as its GOROOT_BOOTSTRAP.

Because we shard tests and slow tests are scheduled first, it shouldn't affect the overall trybot time.

/cc @mdempsky @bcmills @dmitshur

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 13, 2019

Change https://golang.org/cl/167478 mentions this issue: cmd/dist: add a test in misc/reboot to verify that the toolchain can self-bootstrap

@gopherbot gopherbot closed this in 2989abc Mar 13, 2019
@golang golang locked and limited conversation to collaborators Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.