Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: -run running all tests #30764

Closed
santhosh-tekuri opened this issue Mar 12, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@santhosh-tekuri
Copy link
Contributor

commented Mar 12, 2019

What version of Go are you using (go version)?

$ go version
go version go1.10.3 windows/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\rajag\AppData\Local\go-build
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Users\rajag\go
set GORACE=
set GOROOT=C:\Installations\Go
set GOTMPDIR=
set GOTOOLDIR=C:\Installations\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\rajag\AppData\Local\Temp\go-build044115818=/tmp/go-bu
ild -gno-record-gcc-switches

What did you do?

go test -run ///quorumWait -v

What did you expect to see?

no tests to run

What did you see instead?

=== RUN   TestUint64
=== RUN   TestUint64/uint64(0)
=== RUN   TestUint64/uint64(123)
=== RUN   TestUint64/uint64(18446744073709551615)
--- PASS: TestUint64 (0.00s)
    --- PASS: TestUint64/uint64(0) (0.00s)
    --- PASS: TestUint64/uint64(123) (0.00s)
    --- PASS: TestUint64/uint64(18446744073709551615) (0.00s)
=== RUN   TestUint32
=== RUN   TestUint32/uint32(0)
=== RUN   TestUint32/uint32(123)
=== RUN   TestUint32/uint32(4294967295)
--- PASS: TestUint32 (0.00s)
    --- PASS: TestUint32/uint32(0) (0.00s)
    --- PASS: TestUint32/uint32(123) (0.00s)
    --- PASS: TestUint32/uint32(4294967295) (0.00s)
=== RUN   TestUint8
=== RUN   TestUint8/uint8(0)
=== RUN   TestUint8/uint8(100)
=== RUN   TestUint8/uint8(255)
--- PASS: TestUint8 (0.00s)
    --- PASS: TestUint8/uint8(0) (0.00s)
    --- PASS: TestUint8/uint8(100) (0.00s)
    --- PASS: TestUint8/uint8(255) (0.00s)
=== RUN   TestBool
=== RUN   TestBool/bool(true)
=== RUN   TestBool/bool(false)
--- PASS: TestBool (0.00s)
    --- PASS: TestBool/bool(true) (0.00s)
    --- PASS: TestBool/bool(false) (0.00s)
=== RUN   TestBytes
=== RUN   TestBytes/bytes("")
=== RUN   TestBytes/bytes("nonempty")
--- PASS: TestBytes (0.00s)
    --- PASS: TestBytes/bytes("") (0.00s)
    --- PASS: TestBytes/bytes("nonempty") (0.00s)
=== RUN   TestString
=== RUN   TestString/string("")
=== RUN   TestString/string("nonempty")
--- PASS: TestString (0.00s)
    --- PASS: TestString/string("") (0.00s)
    --- PASS: TestString/string("nonempty") (0.00s)
=== RUN   TestMessages
=== RUN   TestMessages/message(*raft.entry)
=== RUN   TestMessages/message(*raft.voteReq)
=== RUN   TestMessages/message(*raft.voteResp)
=== RUN   TestMessages/message(*raft.voteResp)#01
=== RUN   TestMessages/message(*raft.appendEntriesReq)
=== RUN   TestMessages/message(*raft.appendEntriesResp)
=== RUN   TestMessages/message(*raft.installSnapReq)
=== RUN   TestMessages/message(*raft.installSnapResp)
=== RUN   TestMessages/message(*raft.installSnapResp)#01
--- PASS: TestMessages (0.00s)
    --- PASS: TestMessages/message(*raft.entry) (0.00s)
    --- PASS: TestMessages/message(*raft.voteReq) (0.00s)
    --- PASS: TestMessages/message(*raft.voteResp) (0.00s)
    --- PASS: TestMessages/message(*raft.voteResp)#01 (0.00s)
    --- PASS: TestMessages/message(*raft.appendEntriesReq) (0.00s)
    --- PASS: TestMessages/message(*raft.appendEntriesResp) (0.00s)
    --- PASS: TestMessages/message(*raft.installSnapReq) (0.00s)
    --- PASS: TestMessages/message(*raft.installSnapResp) (0.00s)
    --- PASS: TestMessages/message(*raft.installSnapResp)#01 (0.00s)
=== RUN   TestRaft
=== RUN   TestRaft/voting
=== RUN   TestRaft/shutdown
=== RUN   TestRaft/bootstrap
=== RUN   TestRaft/singleNode
=== RUN   TestRaft/tripleNode
=== RUN   TestRaft/leader
=== RUN   TestRaft/leader/quorumWait
=== RUN   TestRaft/behindFollower
=== RUN   TestRaft/update
=== RUN   TestRaft/barrier
=== RUN   TestRaft/query
=== RUN   TestRaft/takeSnapshot
=== RUN   TestRaft/sendSnapshot
=== RUN   TestRaft/changeConfig
=== RUN   TestRaft/nonvoter
=== RUN   TestRaft/promote
--- PASS: TestRaft (4.37s)
    --- PASS: TestRaft/voting (0.28s)
    --- PASS: TestRaft/shutdown (0.00s)
    --- PASS: TestRaft/bootstrap (0.17s)
    --- PASS: TestRaft/singleNode (0.35s)
    --- PASS: TestRaft/tripleNode (0.27s)
    --- PASS: TestRaft/leader (2.26s)
        --- PASS: TestRaft/leader/quorumWait (2.26s)
    --- PASS: TestRaft/behindFollower (0.48s)
    --- PASS: TestRaft/update (0.00s)
    --- PASS: TestRaft/barrier (0.27s)
    --- PASS: TestRaft/query (0.29s)
    --- PASS: TestRaft/takeSnapshot (0.00s)
    --- PASS: TestRaft/sendSnapshot (0.00s)
    --- PASS: TestRaft/changeConfig (0.00s)
    --- PASS: TestRaft/nonvoter (0.00s)
    --- PASS: TestRaft/promote (0.00s)
=== RUN   TestServer
=== RUN   TestServer/requestVote
=== RUN   TestServer/appendEntries
--- PASS: TestServer (0.00s)
    --- PASS: TestServer/requestVote (0.00s)
    --- PASS: TestServer/appendEntries (0.00s)
PASS
ok      github.com/santhosh-tekuri/raft 4.442s

@santhosh-tekuri santhosh-tekuri changed the title testing: --run running all tests testing: -run running all tests Mar 12, 2019

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

As documented at https://golang.org/pkg/testing under "Subtests and Sub-benchmarks," the argument to -run is slash separated, and an empty element matches everything. So when you pass ///quorumWait you are matching every test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.