Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/packages: add to standard library #30773

Open
rsc opened this issue Mar 12, 2019 · 5 comments
Open

go/packages: add to standard library #30773

rsc opened this issue Mar 12, 2019 · 5 comments
Assignees
Milestone

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Mar 12, 2019

We made go/build.Import keep working kind of for modules in Go 1.11,
but as we move toward modules on by default, we should be planning
to have go/packages available in the standard library as a replacement.
This will require making sure we are happy with the API freezing.

/cc @ianthehat @matloob

@rsc rsc added this to the Go1.13 milestone Mar 12, 2019
@mvdan

This comment has been minimized.

Copy link
Member

@mvdan mvdan commented Mar 12, 2019

Would this be one last opportunity to make a small number of breaking API changes, or is the idea that users can switch libraries with zero changes besides the import path?

@matloob matloob self-assigned this Mar 12, 2019
@matloob

This comment has been minimized.

Copy link
Contributor

@matloob matloob commented Mar 12, 2019

I'd like to make a few small breaking changes before we move go/packages to the standard library. At the least, we're not going to expose LoadFiles/LoadImports/LoadTypes/LoadSyntax/LoadAllSyntax in favor of users explicitly specifying what they need.

(The more opportunities to improve/fix go/packages without actually breaking people the better...)

@josharian

This comment has been minimized.

Copy link
Contributor

@josharian josharian commented Mar 12, 2019

@matloob where should we file possible breaking changes to the API? Do you want them here or in separate, cross-references issues?

@matloob

This comment has been minimized.

Copy link
Contributor

@matloob matloob commented Mar 12, 2019

@rsc Before we do this, I think we should have a discussion to make sure that we are okay freezing the API. I'll get in touch with you off line to discuss.

I personally would like some more time to find changes we'd like to make in go/packages before freezing it forever in the standard library, if we plan to do so.

@matloob

This comment has been minimized.

Copy link
Contributor

@matloob matloob commented Mar 12, 2019

@josharian Separate issues would be best. The cross-referencing should help us track them collectively.

@andybons andybons modified the milestones: Go1.13, Go1.14 May 16, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.