x/build: TryBots broken for x/mobile subrepo

[bcmills]

I thought the TryBot failures on https://golang.org/cl/167179 seemed suspicious, so I created https://golang.org/cl/167182 to test the TryBots on a silly no-op change.

Both of the configured TryBots failed for that change too:
https://storage.googleapis.com/go-build-log/a0836481/android-amd64-emu_5da43c59.log
https://storage.googleapis.com/go-build-log/a0836481/linux-amd64-androidemu_3d8ec5df.log

(CC @bradfitz @dmitshur @eliasnaur)

[bradfitz]

Your silly no-no change was quite silly indeed: it was based on a Feb 22nd git parent, while @eliasnaur was still furiously working on getting x/mobile working.

I rebased your test CL and it's running again now against the current x/mobile HEAD.

[bradfitz]

It now passed android-amd64-emu and got an entirely different error (perhaps a flake?) on linux-amd64-androidemu.

@eliasnaur, can you take a look?

Failed on linux-amd64-androidemu: https://storage.googleapis.com/go-build-log/bea58ef3/linux-amd64-androidemu_92ef0445.log

ok  	golang.org/x/mobile/app	0.008s
?   	golang.org/x/mobile/app/internal/apptest	[no test files]
?   	golang.org/x/mobile/app/internal/testapp	[no test files]
?   	golang.org/x/mobile/asset	[no test files]
ok  	golang.org/x/mobile/bind	30.154s
--- FAIL: TestJavaSeqTest (22.56s)
    seq_test.go:124: tmpdir = /workdir/tmp/bind-java-seq-test-030688498
    seq_test.go:181: > Task :preBuild UP-TO-DATE
        > Task :preDebugBuild UP-TO-DATE
        > Task :compileDebugAidl
        > Task :compileDebugRenderscript
        > Task :checkDebugManifest
        > Task :generateDebugBuildConfig
        > Task :generateDebugResValues
        > Task :generateDebugResources
        > Task :packageDebugResources
        > Task :processDebugManifest
        > Task :prepareLintJar
        > Task :javaPreCompileDebug
        > Task :mergeDebugConsumerProguardFiles
        > Task :mergeDebugShaders
        > Task :platformAttrExtractor
        > Task :generateDebugRFile
        > Task :generateDebugSources
        > Task :compileDebugJavaWithJavac
        > Task :extractDebugAnnotations
        > Task :compileDebugShaders
        > Task :generateDebugAssets
        > Task :packageDebugAssets
        > Task :packageDebugRenderscript NO-SOURCE
        > Task :processDebugJavaRes NO-SOURCE
        > Task :transformResourcesWithMergeJavaResForDebug
        > Task :transformClassesAndResourcesWithSyncLibJarsForDebug
        > Task :compileDebugNdk NO-SOURCE
        > Task :mergeDebugJniLibFolders
        > Task :transformNativeLibsWithMergeJniLibsForDebug
        > Task :transformNativeLibsWithStripDebugSymbolForDebug
        > Task :transformNativeLibsWithSyncJniLibsForDebug
        > Task :bundleDebug
        > Task :compileDebugSources
        > Task :assembleDebug
        > Task :preDebugAndroidTestBuild UP-TO-DATE
        > Task :compileDebugAndroidTestAidl
        > Task :processDebugAndroidTestManifest
        > Task :compileDebugAndroidTestRenderscript
        > Task :generateDebugAndroidTestBuildConfig
        > Task :mainApkListPersistenceDebugAndroidTest
        > Task :generateDebugAndroidTestResValues
        > Task :generateDebugAndroidTestResources
        > Task :mergeDebugAndroidTestResources
        > Task :processDebugAndroidTestResources
        > Task :generateDebugAndroidTestSources
        > Task :transformClassesAndResourcesWithPrepareIntermediateJarsForDebug
        > Task :javaPreCompileDebugAndroidTest
        > Task :compileDebugAndroidTestJavaWithJavac
        > Task :compileDebugAndroidTestNdk NO-SOURCE
        > Task :compileDebugAndroidTestSources
        > Task :mergeDebugAndroidTestShaders
        > Task :compileDebugAndroidTestShaders
        > Task :generateDebugAndroidTestAssets
        > Task :mergeDebugAndroidTestAssets
        > Task :transformClassesWithDexBuilderForDebugAndroidTest
        > Task :transformDexArchiveWithExternalLibsDexMergerForDebugAndroidTest
        > Task :transformDexArchiveWithDexMergerForDebugAndroidTest
        > Task :mergeDebugAndroidTestJniLibFolders
        > Task :transformNativeLibsWithIntermediateJniLibsForDebug
        > Task :transformNativeLibsWithMergeJniLibsForDebugAndroidTest
        > Task :processDebugAndroidTestJavaRes NO-SOURCE
        > Task :transformResourcesWithMergeJavaResForDebugAndroidTest
        > Task :validateSigningDebugAndroidTest
        > Task :packageDebugAndroidTest
        > Task :assembleDebugAndroidTest
        
        > Task :connectedDebugAndroidTest
        Starting 42 tests on android-avd(AVD) - 8.0.0
        
        go.SeqTest > testJavaRefKeep[android-avd(AVD) - 8.0.0] �[31mFAILED �[0m
        	junit.framework.AssertionFailedError: want obj not to be kept by Go
        	at go.SeqTest.testJavaRefKeep(SeqTest.java:346)
        
        > Task :connectedDebugAndroidTest FAILED
        
        FAILURE: Build failed with an exception.
        
        * What went wrong:
        Execution failed for task ':connectedDebugAndroidTest'.
        > There were failing tests. See the report at: file:///workdir/tmp/bind-java-seq-test-030688498/build/reports/androidTests/connected/index.html
        
        * Try:
        Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
        
        * Get more help at https://help.gradle.org
        
        BUILD FAILED in 7s
        48 actionable tasks: 48 executed
    seq_test.go:182: failed to run gradle test: exit status 1
FAIL
FAIL	golang.org/x/mobile/bind/java	152.286s
ok  	golang.org/x/mobile/bind/objc	0.035s
ok  	golang.org/x/mobile/bind/seq	0.017s
ok  	golang.org/x/mobile/cmd/gobind	25.942s
ok  	golang.org/x/mobile/cmd/gomobile	0.554s
?   	golang.org/x/mobile/event/key	[no test files]
?   	golang.org/x/mobile/event/lifecycle	[no test files]
?   	golang.org/x/mobile/event/mouse	[no test files]
?   	golang.org/x/mobile/event/paint	[no test files]
?   	golang.org/x/mobile/event/size	[no test files]
?   	golang.org/x/mobile/event/touch	[no test files]
?   	golang.org/x/mobile/example/basic	[no test files]
?   	golang.org/x/mobile/example/bind/hello	[no test files]
?   	golang.org/x/mobile/example/flappy	[no test files]
?   	golang.org/x/mobile/example/network	[no test files]
?   	golang.org/x/mobile/exp/app/debug	[no test files]
?   	golang.org/x/mobile/exp/audio/al	[no test files]
ok  	golang.org/x/mobile/exp/f32	0.007s
ok  	golang.org/x/mobile/exp/font	0.014s
ok  	golang.org/x/mobile/exp/gl/glutil	0.005s [no tests to run]
?   	golang.org/x/mobile/exp/sensor	[no test files]
?   	golang.org/x/mobile/exp/sprite	[no test files]
ok  	golang.org/x/mobile/exp/sprite/clock	0.002s
?   	golang.org/x/mobile/exp/sprite/glsprite	[no test files]
ok  	golang.org/x/mobile/exp/sprite/portable	0.008s
?   	golang.org/x/mobile/geom	[no test files]
?   	golang.org/x/mobile/gl	[no test files]
ok  	golang.org/x/mobile/internal/binres	0.089s
ok  	golang.org/x/mobile/internal/importers	0.030s
ok  	golang.org/x/mobile/internal/importers/java	1.928s
ok  	golang.org/x/mobile/internal/importers/objc	0.013s
?   	golang.org/x/mobile/internal/mobileinit	[no test files]

[bradfitz]

Actually I'll close this and let @eliasnaur open a new bug for x/mobile.

[eliasnaur]

Yes, that was a flake. Thanks for the investigation.

[bradfitz]

@eliasnaur, can you file a bug about the flake and de-flake it? To get these as trybots, we need to get them as un-flaky as possible.

[eliasnaur]

I would have fixed it yesterday but traveling came in the way. I'll deflake this and a related test soon, perhaps today.

[gopherbot]

Change https://golang.org/cl/167657 mentions this issue: bind/java: deflake testJavaRefKeep