Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build: warn in TryBot CL comment if the parent commit is old #30807
It would have been even more helpful if the bot would have told me that instead of requiring human intervention.
The TryBot result for my test said:
Perhaps it also could have said something like:
It looks like the original commit stalled because they couldn't reach a consensus on what the right limit should be. A number of days, a number of commits, some combination of both?
Perhaps we can start with a warning and see if it's too agressive or conservative. And if we're happy with it, consider replacing the warning with an error.
Updates golang/go#19664 Updates golang/go#9858 Updates golang/go#30807 Change-Id: I378979e2745b4d34286a3a038161eb03148771e7 Reviewed-on: https://go-review.googlesource.com/c/build/+/170457 Reviewed-by: Dmitri Shuralyov <email@example.com>