Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: warn in TryBot CL comment if the parent commit is old #30807

Open
bcmills opened this Issue Mar 13, 2019 · 3 comments

Comments

Projects
None yet
5 participants
@bcmills
Copy link
Member

bcmills commented Mar 13, 2019

On #30785, @bradfitz helpfully noticed that the baseline I was testing against was quite old.

It would have been even more helpful if the bot would have told me that instead of requiring human intervention. 馃檪

The TryBot result for my test said:

2 of 2 TryBots failed:
Failed on linux-amd64-androidemu: https://storage.googleapis.com/go-build-log/a0836481/linux-amd64-androidemu_3d8ec5df.log
Failed on android-amd64-emu: https://storage.googleapis.com/go-build-log/a0836481/android-amd64-emu_5da43c59.log

Consult https://build.golang.org/ to see whether they are new failures.

Perhaps it also could have said something like:

WARNING: Base commit xxxxxx (merged Feb. 22, 2019) is older than 7 days.
Results might not reflect current master.

(CC @dmitshur)

@gopherbot gopherbot added this to the Unreleased milestone Mar 13, 2019

@gopherbot gopherbot added the Builders label Mar 13, 2019

@ALTree

This comment has been minimized.

Copy link
Member

ALTree commented Mar 13, 2019

Also see: #19664 (x/build: make trybots refuse to test a commit that's too old), only difference is that you're asking for a warning and not an hard refusal. May be worth to just move the discussion there and decide if a warning of a refusal is better.

@mvdan

This comment has been minimized.

Copy link
Member

mvdan commented Mar 13, 2019

It looks like the original commit stalled because they couldn't reach a consensus on what the right limit should be. A number of days, a number of commits, some combination of both?

Perhaps we can start with a warning and see if it's too agressive or conservative. And if we're happy with it, consider replacing the warning with an error.

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Mar 13, 2019

It stalled on time to implement it more than deciding anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.