Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/gopls: crashes in $GOROOT #30812

Closed
stamblerre opened this issue Mar 13, 2019 · 3 comments
Closed

x/tools/cmd/gopls: crashes in $GOROOT #30812

stamblerre opened this issue Mar 13, 2019 · 3 comments
Assignees
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Mar 13, 2019

Need to handle opening of files in $GOROOT.

@stamblerre stamblerre self-assigned this Mar 13, 2019
@gopherbot gopherbot added this to the Unreleased milestone Mar 13, 2019
@stamblerre stamblerre added the gopls label Mar 13, 2019
@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Apr 4, 2019

This seems to work now. @jayconrod can you confirm, since I believe you initially reported this bug to me?

@jayconrod
Copy link
Contributor

@jayconrod jayconrod commented Apr 4, 2019

Seems to be working now, both at tip and 1.12.1.

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Apr 4, 2019

Awesome, thanks for confirming!

@stamblerre stamblerre closed this Apr 4, 2019
@golang golang locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.