Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go/internal/load: filepath.Split used on a '/'-separated path #30821

Closed
dmitshur opened this Issue Mar 14, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@dmitshur
Copy link
Member

dmitshur commented Mar 14, 2019

On master right now:

_, elem := filepath.Split(p.ImportPath)

Import path is always '/'-separated, but filepath.Split operates on OS-defined file paths that may not be '/'-separated.

This was introduced as part of CL 140863, I don't think it was intentional. See my comment there for details:

https://go-review.googlesource.com/c/go/+/140863/11#message-db0ff6bb2c7b06161ca47de771c4465afa8b1102

/cc @hyangah @bcmills @bradfitz

@dmitshur dmitshur added this to the Go1.13 milestone Mar 14, 2019

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Mar 14, 2019

Change https://golang.org/cl/167503 mentions this issue: cmd/go: use path.Split on import path in DefaultExecName

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Mar 14, 2019

Change https://golang.org/cl/167617 mentions this issue: Revert "[release-branch.go1.12] cmd/go: fix the default build output name for versioned binaries"

gopherbot pushed a commit that referenced this issue Mar 14, 2019

Revert "[release-branch.go1.12] cmd/go: fix the default build output …
…name for versioned binaries"

This reverts commit 746edd4 (CL 167384).

Reason for revert: Dmitri identified a potential problem in https://go-review.googlesource.com/c/go/+/140863/11#message-db0ff6bb2c7b06161ca47de771c4465afa8b1102, and we'd like more time to investigate without holding up the 1.12 release branch.

Updates #27283
Updates #30266
Updates #30821

Change-Id: I49d7bbbe200e80b81899c3bcbf7844717af010aa
Reviewed-on: https://go-review.googlesource.com/c/go/+/167617
Reviewed-by: Andrew Bonventre <andybons@golang.org>

@dmitshur dmitshur self-assigned this Mar 14, 2019

@gopherbot gopherbot closed this in 94563de Mar 22, 2019

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Mar 22, 2019

Change https://golang.org/cl/168958 mentions this issue: [release-branch.go1.12] cmd/go: fix the default build output name for versioned binaries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.