Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestCloseWrite for SOCK_SEQPACKET failing on SmartOS #30840

Closed
bcmills opened this issue Mar 14, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@bcmills
Copy link
Member

commented Mar 14, 2019

Looking at the recent test flakes on solaris-amd64-smartosbuildlet, the vast majority of them are failures in TestCloseWrite.

For an example, see https://build.golang.org/log/f41d2e44b0629db5f3b5e32eec5751b465f4717f:

--- FAIL: TestCloseWrite (0.00s)
    net_test.go:153: got (0, read unixpacket ->/tmp/workdir/tmp/go-nettest264897916: not pollable); want (0, io.EOF)
FAIL
FAIL	net	9.459s

CC @mikioh @bradfitz @ianlancetaylor

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

Most likely due to https://golang.org/cl/166497 "runtime, internal/poll, net: report event scanning error on read event". I suspect that Solaris poll is reporting POLLERR if the other side of a Unix socket is closed, although the man page is uninformative on the point. It would be interesting to know whether POLLHUP was also set.

@ianlancetaylor ianlancetaylor added this to the Go1.13 milestone Mar 15, 2019

@mikioh

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

Sure, I think the fix for #30817 also cures this issue.

@gopherbot

This comment has been minimized.

Copy link

commented Mar 15, 2019

Change https://golang.org/cl/167777 mentions this issue: runtime, internal/poll: report only critical event scanning error

@gopherbot gopherbot closed this in 451a2eb Mar 19, 2019

@mikioh

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

Reopen: it seems like there's something-something between Oracle Solaris and SmartOS.

@mikioh mikioh reopened this Mar 19, 2019

@mikioh mikioh changed the title net: TestCloseWrite flaky on SmartOS builder net: TestCloseWrite for SOCK_SEQPACKET failing on SmartOS Mar 19, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Mar 19, 2019

Change https://golang.org/cl/167782 mentions this issue: runtime: disable event scanning error reporting on solaris

@gopherbot gopherbot closed this in e0181ff Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.