Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: write barrier incorrect on wasm #30871

Closed
aclements opened this issue Mar 15, 2019 · 4 comments
Closed

runtime: write barrier incorrect on wasm #30871

aclements opened this issue Mar 15, 2019 · 4 comments
Assignees
Labels
Milestone

Comments

@aclements
Copy link
Member

@aclements aclements commented Mar 15, 2019

The implementation of the write barrier on wasm incorrectly implements the "deletion" part of the barrier, and has since the code was introduced in Go 1.11. I have a fix. This issue is to track backports.

@aclements aclements added the Arch-Wasm label Mar 15, 2019
@aclements aclements added this to the Go1.13 milestone Mar 15, 2019
@aclements aclements self-assigned this Mar 15, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Mar 15, 2019

Change https://golang.org/cl/167743 mentions this issue: runtime: fix write barrier on wasm

@aclements

This comment has been minimized.

Copy link
Member Author

@aclements aclements commented Mar 15, 2019

@gopherbot, please backport to Go 1.12 and Go 1.11.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Mar 15, 2019

Backport issue(s) opened: #30872 (for 1.11), #30873 (for 1.12).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@aclements

This comment has been minimized.

Copy link
Member Author

@aclements aclements commented Mar 15, 2019

Thanks @gopherbot!

@gopherbot gopherbot closed this in d9db9e3 Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.