Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/ipv4: all cmsg tests fail on FreeBSD 12 kernel running COMPAT_FREEBSD32 #30899

Closed
mikioh opened this issue Mar 18, 2019 · 5 comments
Closed

Comments

@mikioh
Copy link
Contributor

@mikioh mikioh commented Mar 18, 2019

See https://build.golang.org/log/5fff7e020d3329af198bcae137b22c124a7a7f31

:: Running /tmp/workdir/go/bin/go with args ["/tmp/workdir/go/bin/go" "test" "-short" "golang.org/x/net/..."] and env ["PATH=/tmp/workdir/go/bin:/bin:/sbin:/usr/bin:/usr/local/bin" "PWD=/" "HOME=/" "RC_PID=24" "WORKDIR=/tmp/workdir" "GOROOT_BOOTSTRAP=/tmp/workdir/go1.4" "GO_BUILDER_NAME=freebsd-386-12_0" "GOARCH=386" "GOHOSTARCH=386" "GOROOT=/tmp/workdir/go" "GOPATH=/tmp/workdir/gopath" "GOPROXY=http://10.240.0.50:30156" "TMPDIR=/tmp/workdir/tmp" "GOCACHE=/tmp/workdir/gocache"] in dir /tmp/workdir/gopath/src/golang.org/x/net

--- FAIL: TestPacketConnReadWriteMulticastUDP (0.00s)
    multicast_test.go:102: read udp 0.0.0.0:27889: short buffer
--- FAIL: TestPacketConnReadWriteMulticastICMP (0.00s)
    multicast_test.go:204: read ip 0.0.0.0: short buffer
--- FAIL: TestPacketConnConcurrentReadWriteUnicastUDP (0.00s)
    readwrite_test.go:250: read udp 127.0.0.1:22658: short buffer
    readwrite_test.go:250: read udp 127.0.0.1:22658: short buffer
    readwrite_test.go:250: read udp 127.0.0.1:22658: short buffer
--- FAIL: TestPacketConnConcurrentReadWriteUnicast (0.01s)
    --- FAIL: TestPacketConnConcurrentReadWriteUnicast/UDP (0.00s)
        --- FAIL: TestPacketConnConcurrentReadWriteUnicast/UDP/ToFrom (0.00s)
            readwrite_test.go:377: read udp 127.0.0.1:60170: short buffer
            readwrite_test.go:377: read udp 127.0.0.1:60170: short buffer
            readwrite_test.go:377: read udp 127.0.0.1:60170: short buffer
            readwrite_test.go:377: read udp 127.0.0.1:60170: short buffer
            readwrite_test.go:377: read udp 127.0.0.1:60170: short buffer
            readwrite_test.go:377: read udp 127.0.0.1:60170: short buffer
            readwrite_test.go:377: read udp 127.0.0.1:60170: short buffer
            readwrite_test.go:377: read udp 127.0.0.1:60170: short buffer
            readwrite_test.go:377: read udp 127.0.0.1:60170: short buffer
        --- FAIL: TestPacketConnConcurrentReadWriteUnicast/UDP/Batch (0.00s)
            readwrite_test.go:409: short buffer
            readwrite_test.go:409: short buffer
            readwrite_test.go:409: short buffer
            readwrite_test.go:409: short buffer
            readwrite_test.go:409: short buffer
            readwrite_test.go:409: short buffer
            readwrite_test.go:409: short buffer
            readwrite_test.go:409: short buffer
    --- FAIL: TestPacketConnConcurrentReadWriteUnicast/IP (0.00s)
        --- FAIL: TestPacketConnConcurrentReadWriteUnicast/IP/ToFrom (0.00s)
            readwrite_test.go:377: read ip 127.0.0.1: short buffer
            readwrite_test.go:377: read ip 127.0.0.1: short buffer
        --- FAIL: TestPacketConnConcurrentReadWriteUnicast/IP/Batch (0.00s)
            readwrite_test.go:409: short buffer
            readwrite_test.go:409: short buffer
            readwrite_test.go:409: short buffer
            readwrite_test.go:409: short buffer
            readwrite_test.go:409: short buffer
            readwrite_test.go:409: short buffer
            readwrite_test.go:409: short buffer
            readwrite_test.go:409: short buffer
            readwrite_test.go:409: short buffer
--- FAIL: TestPacketConnReadWriteUnicastUDP (0.00s)
    unicast_test.go:65: read udp 127.0.0.1:21928: short buffer
--- FAIL: TestPacketConnReadWriteUnicastICMP (0.00s)
    unicast_test.go:141: read ip 0.0.0.0: short buffer
--- FAIL: TestRawConnReadWriteUnicastICMP (0.00s)
    unicast_test.go:232: read ip 0.0.0.0: short buffer
FAIL
FAIL	golang.org/x/net/ipv4	0.018s
@gopherbot gopherbot added this to the Unreleased milestone Mar 18, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 18, 2019

Change https://golang.org/cl/168077 mentions this issue: ipv4: work around FreeBSD 12 kernel running COMPAT_FREEBSD32

@mikioh
Copy link
Contributor Author

@mikioh mikioh commented Mar 18, 2019

Reopen: at least the fix needs to identify the running kernel version.

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 19, 2019

Change https://golang.org/cl/168297 mentions this issue: ipv4: work around FreeBSD 12 kernel running COMPAT_FREEBSD32

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 5, 2019

Change https://golang.org/cl/170897 mentions this issue: ipv4, ipv6: skip tests on freebsd/386 with previous standard libraries

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 12, 2019

Change https://golang.org/cl/171937 mentions this issue: ipv4: work around FreeBSD 12.0 kernel running COMPAT_FREEBSD32

gopherbot pushed a commit to golang/net that referenced this issue Apr 15, 2019
Followup for CL 168297, a fix was released for the kernel bug https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236737

https://svnweb.freebsd.org/base?view=revision&revision=345741
https://svnweb.freebsd.org/base?view=revision&revision=346019
https://svnweb.freebsd.org/base?view=revision&revision=346020

Thus the bug won't affect 11.3-RELEASE and 12.1-RELEASE when they are out.

Update adjustFreeBSD32 to handle only FreeBSD 12.0-RELEASE ranges of freebsdVersion.

Updates golang/go#30899

Change-Id: I6beeaa55023dbe86a3d6fd8d6d5094516ec6978a
Reviewed-on: https://go-review.googlesource.com/c/net/+/171937
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants