Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: internal/ssa TestNexting failing #30912

Closed
katiehockman opened this issue Mar 18, 2019 · 7 comments

Comments

Projects
None yet
5 participants
@katiehockman
Copy link
Contributor

commented Mar 18, 2019

Change d949d0b (cmd/compile: reorganize init functions) seems to have failed the TestNexting test in the cmd/compile/internal/ssa package for linux-amd64-longtest builds

--- FAIL: TestNexting (10.74s)
    --- FAIL: TestNexting/gdb-dbg-i22558 (0.48s)
        debug_test.go:241: step/next histories differ, diff=
            --- testdata/i22558.gdb-dbg.nexts	2019-03-18 21:16:19.000000000 +0000
            +++ /workdir/tmp/debug_test137844848/test-i22558.gdb-dbg.nexts	2019-03-18 21:42:04.493540912 +0000
            @@ -2,3 +2,10 @@
             19:	func test(t *thing, u *thing) {
             20:		if t.next != nil {
             23:		fmt.Fprintf(os.Stderr, "%s\n", t.name)
            +24:		u.self = u
            +25:		t.self = t
            +26:		t.next = u
            +27:		for _, p := range t.stuff {
            +28:			if isFoo(t, p) {
            +29:				return
            +44:	}
FAIL
FAIL	cmd/compile/internal/ssa	85.797s

https://build.golang.org/log/cb49293c3202a9d78ae2324b5a8217e99dc82e8a

cc @randall77

@katiehockman katiehockman changed the title cmd/compile: internal/ssa TestNexting flaky cmd/compile: internal/ssa TestNexting failing Mar 18, 2019

@randall77

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

@katiehockman

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

This seems to be failing x/tools builds as well:
https://build.golang.org/log/f1e3906e966da6b4c3a47af7cf1b005e95f2c906

@dr2chase

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

I'll give it a look tomorrow, but superficially it looks like the behavior got better.

@ALTree ALTree added the Testing label Mar 19, 2019

@ALTree ALTree added this to the Go1.13 milestone Mar 19, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Mar 19, 2019

Change https://golang.org/cl/168377 mentions this issue: cmd/compile: fix ssa/debug_test.go reference file

@katiehockman

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

@dr2chase will you also be making the fix to the test that failed [ExampleRead] in x/tools as well, or would you like help with that? The fix seems straightforward enough that I can likely do it if needed.

@gopherbot gopherbot closed this in e608ffd Mar 19, 2019

@katiehockman katiehockman reopened this Mar 19, 2019

@katiehockman

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

Re-opening this just to track the other related x/tools bug. Can keep track in a separate issue if that's easier.

@gopherbot

This comment has been minimized.

Copy link

commented Mar 19, 2019

Change https://golang.org/cl/168397 mentions this issue: tools/go: fix gcexportdata example to match new compiler behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.