Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: 'looping trying to add package' is not a helpful error message #30936

Closed
integrii opened this issue Mar 19, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@integrii
Copy link

commented Mar 19, 2019

What version of Go are you using (go version)?

go version go1.12 darwin/amd64

Does this issue reproduce with the latest release?

yes

What did you do?

Use a program that references a package that no longer exists at that location. I was importing a package that imports github.com/docker/docker/container, which imports github.com/opencontainers/runc/libcontainer/label, which does not exist here anymore.

What did you expect to see?

A helpful error telling me that the package specified by a dependency does not exist.

What did you see instead?

A confusing error from here that simply says looping trying to add package.

This is confusing for the user. We should indicate better that the package does not exist or was not found at the specified location. People are hitting this, getting confused, and wasting time, which makes them dislike go modules (and go itself by relationship).

Related issue: #30394

@jayconrod

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

Yep, not a helpful error message.

The fix for #30394 will be to improve the error message though, so I'll close this one as a dup.

@jayconrod jayconrod closed this Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.