Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/go: duplicate symbols when including two main packages in -coverpkg in module mode [1.12 backport] #30937
I'd like CL 168200 to be cherry-picked for 1.12.2.
(I know gopherbot usually opens these issues; I asked politely, but it didn't do it).
…s main packages (more) This fixes two problems missed in CL 164877. First, p.Internal.BuildInfo is now part of the cache key. This is important since p.Internal.BuildInfo causes the build action to synthesize a new source file, which affects the output. Second, recompileForTest is always called for test packages. Previously, it was only called when there were internal test sources, so the fix in CL 164877 did not apply to packages that only had external tests. Fixes #30937 Change-Id: Iac2d7e8914f0313f9ab4222299a866f67889eb2e Reviewed-on: https://go-review.googlesource.com/c/go/+/168200 Run-TryBot: Jay Conrod <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Ian Lance Taylor <email@example.com> (cherry picked from commit d34548e) Reviewed-on: https://go-review.googlesource.com/c/go/+/168717 Run-TryBot: Brad Fitzpatrick <firstname.lastname@example.org> Reviewed-by: Brad Fitzpatrick <email@example.com>