Skip to content

cmd/compile: miscompilation of codependent global var assigments in go1.12 [1.12 backport] #30996

Closed

Description

@gopherbot

@cherrymui requested issue #30977 to be considered for backport to the next 1.12 minor release.

@gopherbot please backport this to Go 1.12.

Activity

  1. added this to the Go1.12.2 milestone on Mar 22, 2019
  2. gopherbot commented on Mar 22, 2019

    @gopherbot
    ContributorAuthor

    Change https://golang.org/cl/168817 mentions this issue: [release-branch.go1.12] cmd/compile: copy volatile values before emitting write barrier call

  3. changed the title [-]cmd/go: miscompilation of codependent global `var` assigments in go1.12 [1.12 backport][/-] [+]cmd/compile: miscompilation of codependent global `var` assigments in go1.12 [1.12 backport][/+] on Mar 28, 2019
  4. thaJeztah commented on Apr 1, 2019

    @thaJeztah
    Contributor

    @randall77 I saw you reviewed https://golang.org/cl/168817 - does that mean this should be labeled CherryPickApproved ?

  5. randall77 commented on Apr 1, 2019

    @randall77
    Contributor

    No, that's still a call for the release guys to make.

    Feel free to add pro-backport arguments to this issue.
    I think it should be backported - it's a nasty bug with no easy workaround, and it was triggered in the wild.

  6. thaJeztah commented on Apr 2, 2019

    @thaJeztah
    Contributor

    Thanks for explaining (and apologies for being a bit noisy 🤗)

    For our next release, this one is definitely a show-stopper, as the result is unpredictable. Timing is a bit unfortunate as we'll have to decide to proceed with Go 1.12, or revert all repositories to Go 1.11.

    @bradfitz (I saw you applied the labels on other issues; so hope you're the right person to ask); ptal

  7. thaJeztah commented on Apr 2, 2019

    @thaJeztah
    Contributor

    For my information; Is there any documentation about the Go release procedure? (or a mailinglist / meeting people can attend to stay informed?)

  8. randall77 commented on Apr 2, 2019

    @randall77
    Contributor
  9. randall77 commented on Apr 2, 2019

    @randall77
    Contributor
  10. thaJeztah commented on Apr 2, 2019

    @thaJeztah
    Contributor

    Awesome, thanks!

  11. gopherbot commented on Apr 2, 2019

    @gopherbot
    ContributorAuthor

    Closed by merging 8acc2ea to release-branch.go1.12.

  12. added a commit that references this issue on Apr 2, 2019
    8acc2ea
  13. locked and limited conversation to collaborators on Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions