You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
cmd/compile: miscompilation of codependent global var assigments in go1.12 [1.12 backport] #30996
changed the title [-]cmd/go: miscompilation of codependent global `var` assigments in go1.12 [1.12 backport][/-][+]cmd/compile: miscompilation of codependent global `var` assigments in go1.12 [1.12 backport][/+]on Mar 28, 2019
No, that's still a call for the release guys to make.
Feel free to add pro-backport arguments to this issue.
I think it should be backported - it's a nasty bug with no easy workaround, and it was triggered in the wild.
Thanks for explaining (and apologies for being a bit noisy 🤗)
For our next release, this one is definitely a show-stopper, as the result is unpredictable. Timing is a bit unfortunate as we'll have to decide to proceed with Go 1.12, or revert all repositories to Go 1.11.
@bradfitz (I saw you applied the labels on other issues; so hope you're the right person to ask); ptal
Activity
gopherbot commentedon Mar 22, 2019
Change https://golang.org/cl/168817 mentions this issue:
[release-branch.go1.12] cmd/compile: copy volatile values before emitting write barrier call[-]cmd/go: miscompilation of codependent global `var` assigments in go1.12 [1.12 backport][/-][+]cmd/compile: miscompilation of codependent global `var` assigments in go1.12 [1.12 backport][/+]thaJeztah commentedon Apr 1, 2019
@randall77 I saw you reviewed https://golang.org/cl/168817 - does that mean this should be labeled
CherryPickApproved?randall77 commentedon Apr 1, 2019
No, that's still a call for the release guys to make.
Feel free to add pro-backport arguments to this issue.
I think it should be backported - it's a nasty bug with no easy workaround, and it was triggered in the wild.
thaJeztah commentedon Apr 2, 2019
Thanks for explaining (and apologies for being a bit noisy 🤗)
For our next release, this one is definitely a show-stopper, as the result is unpredictable. Timing is a bit unfortunate as we'll have to decide to proceed with Go 1.12, or revert all repositories to Go 1.11.
@bradfitz (I saw you applied the labels on other issues; so hope you're the right person to ask); ptal
thaJeztah commentedon Apr 2, 2019
For my information; Is there any documentation about the Go release procedure? (or a mailinglist / meeting people can attend to stay informed?)
randall77 commentedon Apr 2, 2019
https://github.com/golang/go/wiki/MinorReleases
randall77 commentedon Apr 2, 2019
Also https://github.com/golang/go/wiki/Go-Release-Cycle
thaJeztah commentedon Apr 2, 2019
Awesome, thanks!
gopherbot commentedon Apr 2, 2019
Closed by merging 8acc2ea to release-branch.go1.12.
[release-branch.go1.12] cmd/compile: copy volatile values before emit…