Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: auto-reviewers selected for WIP change #31003

Open
thanm opened this issue Mar 22, 2019 · 1 comment

Comments

@thanm
Copy link
Member

commented Mar 22, 2019

While working on a bugfix this week, I uploaded a CL 168818 and then immediately marked it "Work in Progress").

The bot went ahead and auto-assigned reviewers anyhow, which seems a little weird (the point of the WIP label is to say "I'm not quite ready to share this yet"). It would be a nicer workflow if the bot assigned reviewers when the WIP label was removed.

@gopherbot gopherbot added this to the Unreleased milestone Mar 22, 2019

@gopherbot gopherbot added the Builders label Mar 22, 2019

@andybons andybons changed the title x/build/cmd/gerritbot: auto-reviewers selected for WIP change x/build/cmd/gopherbot: auto-reviewers selected for WIP change Mar 22, 2019

@andybons

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

It does check for this: https://github.com/golang/build/blob/master/cmd/gopherbot/gopherbot.go#L1641

In this case, according to maintner, it didn't see a WIP when it assigned those reviewers. It's possible that by the time it got to this change, ten minutes or more had passed and the version it saw was not WIP. That's just a guess, though.

@dmitshur @bradfitz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.