Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build/cmd/gopherbot: auto-reviewers selected for WIP change #31003
While working on a bugfix this week, I uploaded a CL 168818 and then immediately marked it "Work in Progress").
The bot went ahead and auto-assigned reviewers anyhow, which seems a little weird (the point of the WIP label is to say "I'm not quite ready to share this yet"). It would be a nicer workflow if the bot assigned reviewers when the WIP label was removed.
It does check for this: https://github.com/golang/build/blob/master/cmd/gopherbot/gopherbot.go#L1641
In this case, according to maintner, it didn't see a WIP when it assigned those reviewers. It's possible that by the time it got to this change, ten minutes or more had passed and the version it saw was not WIP. That's just a guess, though.