testing: benchmark results can be dropped entirely (regression) #31005
Labels
Comments
The fix I just sent for #30997 should also fix this. Unfortunately, I'm not sure there's a good way to reliably test this. I bet some of the builders are slow enough that you can't produce a ns/op value < 1. |
Change https://golang.org/cl/168937 mentions this issue: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is related to #30997.
CL 166717 caused another, slightly different regression: in some cases, the ns/op number can be dropped entirely from the output.
Example (taken from the repro case in #30928):
Before CL 166717:
After CL 166717:
cc @aclements @josharian
@aclements if you're busy, I can send a CL for these issues.
The text was updated successfully, but these errors were encountered: