Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto: extract non-crypto parts from x/crypto/ssh/terminal into separate library #31044

Open
tandr opened this issue Mar 26, 2019 · 1 comment

Comments

@tandr
Copy link

commented Mar 26, 2019

What version of Go are you using (go version)?

$ go version
go version go1.12.1 darwin/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
not important

What did you do?

import (
	"os"
	"golang.org/x/crypto/ssh/terminal"
)

// abridged version
func checkIsTerminal(fd *osFile) bool {
	if fd != nil {
		return terminal.IsTerminal(int(fd.Fd()))
	}
	return false
}

What did you expect to see?

no "crypto" or "ssh" wording in import directive - there is nothing is going on what is cryptography-related

What did you see instead?

Since it has "crypto" part in a path, we have to explain to our legal department what do we do here, why do we need it, and how it affects whole solution software export restrictions.

It would be nice to have non-crypto and non-password related parts to be moved into library that has nothing to do with "crypto" or "ssh", as it definitely has more utility than just for ssh-related work.

@gopherbot gopherbot added this to the Unreleased milestone Mar 26, 2019

@dmitshur

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

We've created golang.org/x/term exactly for this purpose. But the move hasn't been done yet.

This is related to issue #13104.

/cc @matloob @bradfitz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.