Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/review: use alternative remote repository #31046

Open
carnott-snap opened this issue Mar 26, 2019 · 1 comment

Comments

@carnott-snap
Copy link

commented Mar 26, 2019

What version of Go are you using (go version)?

$ go version
go version go1.12.1 linux/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/user/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/user/go"
GOPROXY=""
GORACE=""
GOROOT="/home/user/.local/share/umake/go/go-lang"
GOTMPDIR=""
GOTOOLDIR="/home/user/.local/share/umake/go/go-lang/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/user/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build019412724=/tmp/go-build -gno-record-gcc-switches"

What did you do?

git codereview mail

What did you expect to see?

remote: Processing changes: refs: 1, new: 1, done    
remote: 
remote: SUCCESS
remote: 
remote:   https://go-review.googlesource.com/c/gddo/+/123456 pkg: commit message [NEW]
remote: 

What did you see instead?

In #9266, this high level issue was identified: git-codereview only references the origin remote when pushing changes. While this behavior is probably nice in preventing unnecessary configuration via git branch --set-upstream-to=, but it makes having an origin that does not point to go.googlesource.com impossible. Would it be possible to read the remote out of the gitconfig or allow overriding via flags?

@gopherbot gopherbot added this to the Unreleased milestone Mar 26, 2019

@agnivade

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.