Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/xml: must handle pointers in anonymous fields #3108

Closed
niemeyer opened this Issue Feb 23, 2012 · 6 comments

Comments

Projects
None yet
3 participants
@niemeyer
Copy link
Contributor

niemeyer commented Feb 23, 2012

This works today, with Anon's fields embedded in T:

    type T struct {
        Anon
    }

This doesn't, and Anon gets ignored:

    type T struct {
        *Anon
    }

Both should be equivalent.
@niemeyer

This comment has been minimized.

Copy link
Contributor Author

niemeyer commented Feb 23, 2012

Comment 1:

Labels changed: added priority-go1, removed priority-triage.

@rsc

This comment has been minimized.

Copy link
Contributor

rsc commented Feb 23, 2012

Comment 2:

After Go 1, like json's anonymous field support.

Labels changed: added priority-later, removed priority-go1.

@niemeyer

This comment has been minimized.

Copy link
Contributor Author

niemeyer commented Feb 23, 2012

Comment 3:

Fixed in this CL, waiting for Go 1 to go one:
http://golang.org/cl/5694044/

Status changed to Started.

@niemeyer

This comment has been minimized.

Copy link
Contributor Author

niemeyer commented Apr 17, 2012

Comment 4:

Issue #3541 has been merged into this issue.

@niemeyer

This comment has been minimized.

Copy link
Contributor Author

niemeyer commented Apr 17, 2012

Comment 5:

Can we look at this for Go 1.1?

Labels changed: added priority-soon, go1.1, removed priority-later.

@niemeyer

This comment has been minimized.

Copy link
Contributor Author

niemeyer commented May 17, 2012

Comment 6:

This issue was closed by revision 9242a90.

Status changed to Fixed.

@niemeyer niemeyer added fixed labels May 17, 2012

@mikioh mikioh changed the title xml must handle pointers in anonymous fields encoding/xml: must handle pointers in anonymous fields Jan 9, 2015

@rsc rsc added this to the Go1.1 milestone Apr 14, 2015

@rsc rsc removed the go1.1 label Apr 14, 2015

@golang golang locked and limited conversation to collaborators Jun 24, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.