Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: skip files tagged `ignore` in `go mod vendor` #31088

Closed
bcmills opened this Issue Mar 27, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@bcmills
Copy link
Member

commented Mar 27, 2019

In reviewing https://golang.org/cl/169637, I noticed that one of the larger files added in https://golang.org/cl/164623 is src/vendor/golang.org/x/text/unicode/norm/maketables.go, which is tagged // +build ignore.

Such files are never included as part of the build graph and explicitly ignored by go mod tidy (#29598), so we should filter them out, much as we already filter out test sources and data (see https://golang.org/cl/122256).

CC @jayconrod @mpvl; compare #25873; contrast #26366.

@bcmills bcmills added this to the Go1.13 milestone Mar 27, 2019

@bcmills bcmills self-assigned this Mar 27, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Apr 19, 2019

Change https://golang.org/cl/172978 mentions this issue: cmd/go/internal/modcmd: skip files with the "ignore" constraint in 'go mod vendor'

@gopherbot

This comment has been minimized.

Copy link

commented Apr 19, 2019

Change https://golang.org/cl/172979 mentions this issue: {,cmd}/vendor: rerun 'go mod vendor' to prune ignored files

@gopherbot gopherbot closed this in 7f16126 Apr 19, 2019

gopherbot pushed a commit that referenced this issue Apr 19, 2019

{,cmd/}vendor: rerun 'go mod vendor' to prune ignored files
Updates #31088

Change-Id: Ia126e4e83ac5cb12c2c4151d5e5c975497598f24
Reviewed-on: https://go-review.googlesource.com/c/go/+/172979
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.