Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: skip files tagged `ignore` in `go mod vendor` #31088

Closed
bcmills opened this issue Mar 27, 2019 · 2 comments
Closed

cmd/go: skip files tagged `ignore` in `go mod vendor` #31088

bcmills opened this issue Mar 27, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Mar 27, 2019

In reviewing https://golang.org/cl/169637, I noticed that one of the larger files added in https://golang.org/cl/164623 is src/vendor/golang.org/x/text/unicode/norm/maketables.go, which is tagged // +build ignore.

Such files are never included as part of the build graph and explicitly ignored by go mod tidy (#29598), so we should filter them out, much as we already filter out test sources and data (see https://golang.org/cl/122256).

CC @jayconrod @mpvl; compare #25873; contrast #26366.

@bcmills bcmills added this to the Go1.13 milestone Mar 27, 2019
@bcmills bcmills self-assigned this Mar 27, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Apr 19, 2019

Change https://golang.org/cl/172978 mentions this issue: cmd/go/internal/modcmd: skip files with the "ignore" constraint in 'go mod vendor'

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Apr 19, 2019

Change https://golang.org/cl/172979 mentions this issue: {,cmd}/vendor: rerun 'go mod vendor' to prune ignored files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.