Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: response type doc comment grammar #31096

Closed
jecolon opened this issue Mar 28, 2019 · 1 comment

Comments

Projects
None yet
4 participants
@jecolon
Copy link

commented Mar 28, 2019

What version of Go are you using (go version)?

$ go version
go version go1.11 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jecolon/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/jecolon/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/sy/ss3ktx6n4slflxpbn3kf96bm0000gn/T/go-build119449844=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Read the docs at golang.org/pkg/net/http

What did you expect to see?

// As of Go 1.12, the Body will also implement io.Writer
// on a successful "101 Switching Protocols" response,

What did you see instead?

// As of Go 1.12, the Body will be also implement io.Writer
// on a successful "101 Switching Protocols" responses,

@bradfitz bradfitz changed the title net/http response type doc comment grammar net/http: response type doc comment grammar Mar 28, 2019

@bradfitz bradfitz self-assigned this Mar 28, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Mar 28, 2019

Change https://golang.org/cl/169683 mentions this issue: net/http: fix typo in Response.Body field docs

@dmitshur dmitshur added this to the Go1.13 milestone Mar 28, 2019

@dmitshur dmitshur added the NeedsFix label Mar 28, 2019

@gopherbot gopherbot closed this in ea9eddb Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.