Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go directive is not only added during go mod init, but also under other conditions that are hard to deduce [1.12 backport] #31117

Closed
gopherbot opened this issue Mar 28, 2019 · 5 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 28, 2019

@bcmills requested issue #30790 to be considered for backport to the next 1.12 minor release.

@gopherbot, please backport to 1.12: the current behavior is confusing, and the fix is small

@julieqiu

This comment has been minimized.

Copy link

@julieqiu julieqiu commented Apr 24, 2019

@bcmills @jayconrod @dmitshur - would it be considered a serious problem with no workaround?

Under our policy at https://github.com/golang/go/wiki/MinorReleases, only fixes for security issues, serious problems with no workaround, and documentation fixes will be backported.

@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Apr 30, 2019

I think this qualifies as a serious problem with no workaround: it causes the go command to add unintended go directives under circumstances that are difficult for users to predict.

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Apr 30, 2019

@bcmills, why is this problem serious? I don't see it having any impact at all!

@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Apr 30, 2019

It can cause significant confusion for authors of standalone modules (that is, modules that lack any external requirements).

(That said, my notion of “significant” may differ from yours, so I won't be at all offended if the backport is declined.)

@andybons

This comment has been minimized.

Copy link
Member

@andybons andybons commented May 6, 2019

While confusing, this doesn't really qualify as a serious problem (programs outright breaking). Declining.

@andybons andybons closed this May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.