Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: ensure that some builder runs runtime.TestLldbPython #31123

Closed
josharian opened this issue Mar 28, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@josharian
Copy link
Contributor

commented Mar 28, 2019

Enabling modules from runtime.TestLldbPython: #30751. But none of the builders failed. This issue is to figure out why, and ensure that some builder is running that test going forward. The problem may be that we need to run /usr/sbin/DevToolsSecurity -enable on the macOS builders; see discussion at #30751.

cc @dmitshur @bcmills

@josharian

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

I have hit a third flavor of TestLldbPython failure: #31188. I wonder whether I am currently the only one running this test; all.bash has been broken for me one way or another for almost a month.

@gopherbot

This comment has been minimized.

Copy link

commented Apr 1, 2019

Change https://golang.org/cl/170339 mentions this issue: cmd/buildlet: enable developer mode on macOS

@gopherbot

This comment has been minimized.

Copy link

commented Apr 2, 2019

Change https://golang.org/cl/170438 mentions this issue: cmd/buildlet: use sudo to enable developer mode on Macs

gopherbot pushed a commit to golang/build that referenced this issue Apr 2, 2019

cmd/buildlet: use sudo to enable developer mode on Macs
Apparently Josh's intuition in CL 170339 was correct. We do need sudo.
Sometimes. It's weird. It works without sudo with gomote, but not
during start-up. The environment is slightly different.

In any case, sudo works. Verified on macOS 10.10, 10.11, 10.12, and 10.14.

Updates golang/go#31123

Change-Id: Idc4ace816a5d8e19bbb124663ca186fdf74b188c
Reviewed-on: https://go-review.googlesource.com/c/build/+/170438
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.