Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: keep variable declaration order in debug_info #31133

Open
dlsniper opened this issue Mar 29, 2019 · 8 comments
Open

cmd/compile: keep variable declaration order in debug_info #31133

dlsniper opened this issue Mar 29, 2019 · 8 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. Debugging NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@dlsniper
Copy link
Contributor

Rather than adding DeclColumn info to debug_info, it would be great to write the variables in the declaration order. This would make it easier to display the variables in a predictable and consistent order while debugging and thus better align with the source code presentation.

@ianlancetaylor
Copy link
Contributor

The issue is labeled debug/dwarf, but are you asking for a change in the debug/dwarf package or a change in the compiler?

@aarzilli
Copy link
Contributor

it's a change to the compiler, it should be labeled cmd/compile.

@dlsniper dlsniper changed the title debug/dwarf: keep variable declaration order in debug_info cmd/compile: keep variable declaration order in debug_info Mar 29, 2019
@dlsniper
Copy link
Contributor Author

Updated, sorry, I don't particularly know these areas. Thank you for the heads-up.

@julieqiu julieqiu added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 22, 2019
@julieqiu julieqiu added this to the Go1.13 milestone Apr 22, 2019
@julieqiu
Copy link
Member

/cc @randall77

@randall77
Copy link
Contributor

@dr2chase

@dr2chase
Copy link
Contributor

I'll give this a look.

@dr2chase
Copy link
Contributor

There's no test that verifies what you'd hope to be looking for, is there?

And is the intended outcome "better debugging, once the debuggers are adapted to this change"?

I thought I found the offending sort yesterday in an old CL, but it appears to have been moved since then.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/173439 mentions this issue: cmd/compile: sort DWARF variable info by source position

@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. Debugging NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: Triage Backlog
Development

No branches or pull requests

10 participants