Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: keep variable declaration order in debug_info #31133

Open
dlsniper opened this issue Mar 29, 2019 · 8 comments

Comments

@dlsniper
Copy link
Contributor

@dlsniper dlsniper commented Mar 29, 2019

Rather than adding DeclColumn info to debug_info, it would be great to write the variables in the declaration order. This would make it easier to display the variables in a predictable and consistent order while debugging and thus better align with the source code presentation.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Mar 29, 2019

The issue is labeled debug/dwarf, but are you asking for a change in the debug/dwarf package or a change in the compiler?

@aarzilli

This comment has been minimized.

Copy link
Contributor

@aarzilli aarzilli commented Mar 29, 2019

it's a change to the compiler, it should be labeled cmd/compile.

@dlsniper dlsniper changed the title debug/dwarf: keep variable declaration order in debug_info cmd/compile: keep variable declaration order in debug_info Mar 29, 2019
@dlsniper

This comment has been minimized.

Copy link
Contributor Author

@dlsniper dlsniper commented Mar 29, 2019

Updated, sorry, I don't particularly know these areas. Thank you for the heads-up.

@julieqiu julieqiu added this to the Go1.13 milestone Apr 22, 2019
@julieqiu

This comment has been minimized.

Copy link

@julieqiu julieqiu commented Apr 22, 2019

@randall77

This comment has been minimized.

Copy link
Contributor

@randall77 randall77 commented Apr 22, 2019

@dr2chase

This comment has been minimized.

Copy link
Contributor

@dr2chase dr2chase commented Apr 22, 2019

I'll give this a look.

@dr2chase

This comment has been minimized.

Copy link
Contributor

@dr2chase dr2chase commented Apr 23, 2019

There's no test that verifies what you'd hope to be looking for, is there?

And is the intended outcome "better debugging, once the debuggers are adapted to this change"?

I thought I found the offending sort yesterday in an old CL, but it appears to have been moved since then.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Apr 23, 2019

Change https://golang.org/cl/173439 mentions this issue: cmd/compile: sort DWARF variable info by source position

@heschik heschik added the Debugging label Apr 25, 2019
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.