Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: get some.domain.net/... no longer works with custom domains #31241

Closed
alandonovan opened this issue Apr 3, 2019 · 3 comments
Closed

cmd/go: get some.domain.net/... no longer works with custom domains #31241

alandonovan opened this issue Apr 3, 2019 · 3 comments

Comments

@alandonovan
Copy link
Contributor

@alandonovan alandonovan commented Apr 3, 2019

% ~/go1.10/bin/go version
go version go1.10.3 linux/amd64
% ~/go1.10/bin/go get -v -u go.starlark.net/...
Fetching https://go.starlark.net/cmd/starlark?go-get=1
Parsing meta tags from https://go.starlark.net/cmd/starlark?go-get=1 (status code 200)
get "go.starlark.net/cmd/starlark": found meta tag get.metaImport{Prefix:"go.starlark.net", VCS:"git", RepoRoot:"https://github.com/google/starlark-go"} at https://go.starlark.net/cmd/starlark?go-get=1
get "go.starlark.net/cmd/starlark": verifying non-authoritative meta tag
Fetching https://go.starlark.net?go-get=1
Parsing meta tags from https://go.starlark.net?go-get=1 (status code 200)
go.starlark.net (download)
...
etc, success

% ~/goroot/bin/go version
go version devel +e9d1273997 Wed Apr 3 20:39:58 2019 +0000 linux/amd64
% ~/goroot/bin/go get -v -u go.starlark.net/...
Fetching https://go.starlark.net/...?go-get=1
Parsing meta tags from https://go.starlark.net/...?go-get=1 (status code 404)
Fetching https://go.starlark.net?go-get=1
Parsing meta tags from https://go.starlark.net?go-get=1 (status code 200)
get "go.starlark.net": found meta tag get.metaImport{Prefix:"go.starlark.net", VCS:"git", RepoRoot:"https://github.com/google/starlark-go"} at https://go.starlark.net?go-get=1
go: finding go.starlark.net latest
go get go.starlark.net/...: unrecognized import path "go.starlark.net/..." (parse https://go.starlark.net/...?go-get=1: no go-import meta tags ())

Observe that the first command does one Fetch per package in the expansion of go.starlark.net/... whereas the second fetches https://go.starlark.net/...?go-get=1, which doesn't exist.

This breaks the google3 update.go script for custom domains.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Apr 8, 2019

Change https://golang.org/cl/171138 mentions this issue: cmd/go: handle wildcards for unknown modules in "go get"

@myitcv

This comment has been minimized.

Copy link
Member

@myitcv myitcv commented Apr 8, 2019

Is this a dup of #29363?

@jayconrod

This comment has been minimized.

Copy link
Contributor

@jayconrod jayconrod commented Apr 8, 2019

Yes, I'll close this in favor of #29363. Looks like my CL will need to be updated to handle wildcards inside a module, too.

@jayconrod jayconrod closed this Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.